[GitHub] [kafka] mdedetrich commented on pull request #10648: KAFKA-9726: Add IdentityReplicationPolicy for MM2
mdedetrich commented on pull request #10648: URL: https://github.com/apache/kafka/pull/10648#issuecomment-848567812 As discussed in the mailing list, the other PR is more suitable since it doesn't require a KIP, I will close this PR (it can be reopened later if something else changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mdedetrich commented on pull request #10648: KAFKA-9726: Add IdentityReplicationPolicy for MM2
mdedetrich commented on pull request #10648: URL: https://github.com/apache/kafka/pull/10648#issuecomment-837469565 KIP has been created at https://cwiki.apache.org/confluence/display/KAFKA/KIP-737%3A+Add+canTrackSource+to+ReplicationPolicy and a new thread has been started in the apache-dev mailing list for this topic (let me know if anything more needs to be done). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mdedetrich commented on pull request #10648: KAFKA-9726: Add IdentityReplicationPolicy for MM2
mdedetrich commented on pull request #10648: URL: https://github.com/apache/kafka/pull/10648#issuecomment-835180661 @mimaison I have just renamed `LegacyRepliicationPolicy` to `IdentityReplicationPolicy` and forced pushed the branch. @ryannedolan I will have a look at https://github.com/apache/kafka/pull/10652 early next week to see if I can avoid adding the method to the public interface otherwise I will create a KIP as it appears to be required. Are you guys happy with the `canTrackSource` name should it be needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org