[GitHub] [kafka] mehbey commented on pull request #13681: KAFKA-14133: Migrate ActiveTaskCreator mock in TaskManagerTest to Mockito
mehbey commented on PR #13681: URL: https://github.com/apache/kafka/pull/13681#issuecomment-1570933391 @cadonna Thank you for the review. Addressed all outstanding comments. Please take another look when you get some time. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mehbey commented on pull request #13681: KAFKA-14133: Migrate ActiveTaskCreator mock in TaskManagerTest to Mockito
mehbey commented on PR #13681: URL: https://github.com/apache/kafka/pull/13681#issuecomment-1548206878 @machi1990, thank you for the review. I have addressed your comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mehbey commented on pull request #13681: KAFKA-14133: Migrate ActiveTaskCreator mock in TaskManagerTest to Mockito
mehbey commented on PR #13681: URL: https://github.com/apache/kafka/pull/13681#issuecomment-1546424538 addressed all comments from @clolov. @cadonna - when you get a chance would you be able to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mehbey commented on pull request #13681: KAFKA-14133: Migrate ActiveTaskCreator mock in TaskManagerTest to Mockito
mehbey commented on PR #13681: URL: https://github.com/apache/kafka/pull/13681#issuecomment-1544909428 > Thank you for the review @clolov - I will address the comments shortly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mehbey commented on pull request #13681: KAFKA-14133: Migrate ActiveTaskCreator mock in TaskManagerTest to Mockito
mehbey commented on PR #13681: URL: https://github.com/apache/kafka/pull/13681#issuecomment-1539231000 Verified that failing Testing are not related to this change ``` [2023-05-08T22:22:09.340Z] 1: Task failed with an exception. [2023-05-08T22:22:09.340Z] --- [2023-05-08T22:22:09.340Z] * What went wrong: [2023-05-08T22:22:09.340Z] Execution failed for task ':streams:upgrade-system-tests-0102:integrationTest'. [2023-05-08T22:22:09.340Z] > Process 'Gradle Test Executor 151' finished with non-zero exit value 1 [2023-05-08T22:22:09.340Z] This problem might be caused by incorrect test process configuration. [2023-05-08T22:22:09.340Z] Please refer to the test execution section in the User Manual at https://docs.gradle.org/8.1.1/userguide/java_testing.html#sec:test_execution [2023-05-08T22:22:09.340Z] [2023-05-08T22:22:09.340Z] * Try: [2023-05-08T22:22:09.340Z] > Run with --stacktrace option to get the stack trace. [2023-05-08T22:22:09.340Z] > Run with --info or --debug option to get more log output. [2023-05-08T22:22:09.340Z] > Run with --scan to get full insights. [2023-05-08T22:22:09.340Z] == [2023-05-08T22:22:09.340Z] [2023-05-08T22:22:09.340Z] 2: Task failed with an exception. [2023-05-08T22:22:09.340Z] --- [2023-05-08T22:22:09.340Z] * What went wrong: [2023-05-08T22:22:09.340Z] Execution failed for task ':connect:mirror:integrationTest'. [2023-05-08T22:22:09.340Z] > Process 'Gradle Test Executor 130' finished with non-zero exit value 137 [2023-05-08T22:22:09.340Z] This problem might be caused by incorrect test process configuration. [2023-05-08T22:22:09.340Z] Please refer to the test execution section in the User Manual at https://docs.gradle.org/8.1.1/userguide/java_testing.html#sec:test_execution [2023-05-08T22:22:09.340Z] [2023-05-08T22:22:09.340Z] * Try: [2023-05-08T22:22:09.340Z] > Run with --stacktrace option to get the stack trace. [2023-05-08T22:22:09.340Z] > Run with --info or --debug option to get more log output. [2023-05-08T22:22:09.340Z] > Run with --scan to get full insights. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mehbey commented on pull request #13681: KAFKA-14133: Migrate ActiveTaskCreator mock in TaskManagerTest to Mockito
mehbey commented on PR #13681: URL: https://github.com/apache/kafka/pull/13681#issuecomment-1538991259 Addressed Divij's comment and re-based with the latest changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
