[GitHub] [kafka] mimaison commented on a change in pull request #9726: KAFKA-10833: Expose task configurations in Connect REST API

2021-02-04 Thread GitBox 


mimaison commented on a change in pull request #9726:
URL: https://github.com/apache/kafka/pull/9726#discussion_r570545828



##
File path: 
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java
##
@@ -188,6 +188,16 @@ public ConnectorInfo getConnector(final 
@PathParam("connector") String connector
 return completeOrForwardRequest(cb, "/connectors/" + connector + 
"/config", "GET", headers, null, forward);
 }
 
+@GET
+@Path("/{connector}/tasks-config")
+public Map> getTasksConfig(final 
@PathParam("connector") String connector,
+  final @Context HttpHeaders 
headers,

Review comment:
   You mean something like this?
   ```java
@GET
   @Path("/{connector}/tasks-config")
   public Map> getTasksConfig(
   final @PathParam("connector") String connector,
   final @Context HttpHeaders headers,
   final @QueryParam("forward") Boolean forward) throws Throwable {
   FutureCallback>> cb = new 
FutureCallback<>();
   ...
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] mimaison commented on a change in pull request #9726: KAFKA-10833: Expose task configurations in Connect REST API

2021-02-05 Thread GitBox 


mimaison commented on a change in pull request #9726:
URL: https://github.com/apache/kafka/pull/9726#discussion_r570545828



##
File path: 
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java
##
@@ -188,6 +188,16 @@ public ConnectorInfo getConnector(final 
@PathParam("connector") String connector
 return completeOrForwardRequest(cb, "/connectors/" + connector + 
"/config", "GET", headers, null, forward);
 }
 
+@GET
+@Path("/{connector}/tasks-config")
+public Map> getTasksConfig(final 
@PathParam("connector") String connector,
+  final @Context HttpHeaders 
headers,

Review comment:
   You mean something like this?
   ```java
@GET
   @Path("/{connector}/tasks-config")
   public Map> getTasksConfig(
   final @PathParam("connector") String connector,
   final @Context HttpHeaders headers,
   final @QueryParam("forward") Boolean forward) throws Throwable {
   FutureCallback>> cb = new 
FutureCallback<>();
   ...
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org