[GitHub] [kafka] mjsax commented on a change in pull request #10565: KAFKA-12691: Add case where task can be considered idling
mjsax commented on a change in pull request #10565: URL: https://github.com/apache/kafka/pull/10565#discussion_r617150002 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -692,6 +699,7 @@ public boolean process(final long wallClockTime) { return false; } } +timeCurrentIdlingStarted = Optional.empty(); Review comment: We only set `record = partitionGroup.nextRecord(recordInfo, wallClockTime);` above, ie, only after the task is processable. Hence, the scenario you describe should not happen IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #10565: KAFKA-12691: Add case where task can be considered idling
mjsax commented on a change in pull request #10565: URL: https://github.com/apache/kafka/pull/10565#discussion_r616324780 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -692,6 +699,7 @@ public boolean process(final long wallClockTime) { return false; } } +timeCurrentIdlingStarted = Optional.empty(); Review comment: Why do we need this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org