[GitHub] [kafka] mjsax commented on a diff in pull request #13365: KAFKA-14491: [17/N] Refactor segments cleanup logic
mjsax commented on code in PR #13365: URL: https://github.com/apache/kafka/pull/13365#discussion_r1134610789 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegments.java: ## @@ -57,6 +57,11 @@ public void openExisting(final ProcessorContext context, final long streamTime) physicalStore.openDB(context.appConfigs(), context.stateDir()); } +@Override +public void cleanupExpiredSegments(final long streamTime) { +super.cleanupExpiredSegments(streamTime); Review Comment: If we only call `super...` why do we need to overwrite the method to begin with? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mjsax commented on a diff in pull request #13365: KAFKA-14491: [17/N] Refactor segments cleanup logic
mjsax commented on code in PR #13365: URL: https://github.com/apache/kafka/pull/13365#discussion_r1142849436 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegments.java: ## @@ -57,6 +57,11 @@ public void openExisting(final ProcessorContext context, final long streamTime) physicalStore.openDB(context.appConfigs(), context.stateDir()); } +@Override +public void cleanupExpiredSegments(final long streamTime) { +super.cleanupExpiredSegments(streamTime); Review Comment: Ah. I see. Guess it would get clear quickly in an IDE -- just hard to see on GitHub. Seems fine w/o a comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org