[GitHub] [kafka] mjsax commented on a diff in pull request #13527: Revert "KAFKA-14318: KIP-878, Introduce partition autoscaling configs (#12962)"

[via GitHub]

mjsax commented on code in PR #13527:
URL: https://github.com/apache/kafka/pull/13527#discussion_r1167196102


##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignorTest.java:
##
@@ -71,7 +67,23 @@
 import static org.hamcrest.Matchers.not;
 import static org.junit.Assert.fail;
 
-public class HighAvailabilityTaskAssignorTest {
+public class HighAvailabilityTaskAssignorTest {
+private final AssignmentConfigs configWithoutStandbys = new 
AssignmentConfigs(
+/*acceptableRecoveryLag*/ 100L,
+/*maxWarmupReplicas*/ 2,
+/*numStandbyReplicas*/ 0,
+/*probingRebalanceIntervalMs*/ 60 * 1000L,
+/*rackAwareAssignmentTags*/ EMPTY_RACK_AWARE_ASSIGNMENT_TAGS
+);
+
+private final AssignmentConfigs configWithStandbys = new AssignmentConfigs(

Review Comment:
   Sure. Actually don't know why the PR removed these -- don't have enough 
context on the details -- just did a `git revert`.
   
   You wanna do a PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] mjsax commented on a diff in pull request #13527: Revert "KAFKA-14318: KIP-878, Introduce partition autoscaling configs (#12962)"

[via GitHub]

mjsax commented on code in PR #13527:
URL: https://github.com/apache/kafka/pull/13527#discussion_r1167194742


##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java:
##
@@ -261,41 +261,29 @@ public interface AssignmentListener {
 void onAssignmentComplete(final boolean stable);
 }
 
-/**
- * NOTE: any StreamsConfig you add here MUST be passed in to the consumer 
via

Review Comment:
   Maybe -- I literally just just did a `git revert` -- but easy to keep.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org