mumrah commented on code in PR #14046: URL: https://github.com/apache/kafka/pull/14046#discussion_r1269710067
########## clients/src/main/java/org/apache/kafka/common/errors/StaleMemberEpochException.java: ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.errors; + +import org.apache.kafka.common.annotation.InterfaceStability; + +@InterfaceStability.Evolving +public class StaleMemberEpochException extends ApiException { Review Comment: I know there isn't much precedent for this, but it might be useful to include a doc string here explaining which RPC this error is used in and at what version ########## clients/src/main/resources/common/message/OffsetCommitRequest.json: ########## @@ -31,13 +31,19 @@ // version 7 adds a new field called groupInstanceId to indicate member identity across restarts. // // Version 8 is the first flexible version. - "validVersions": "0-8", + // + // Version 9 is the first version that can be used with the new consumer group protocol (KIP-848). The + // request is the same as version 8. + // Version 9 is added as part of KIP-848 and is still under development. Hence, the last version of the + // API is not exposed by default by brokers unless explicitly enabled. + "latestVersionUnstable": true, + "validVersions": "0-9", "flexibleVersions": "8+", "fields": [ { "name": "GroupId", "type": "string", "versions": "0+", "entityType": "groupId", "about": "The unique group identifier." }, - { "name": "GenerationId", "type": "int32", "versions": "1+", "default": "-1", "ignorable": true, - "about": "The generation of the group." }, + { "name": "GenerationIdOrMemberEpoch", "type": "int32", "versions": "1+", "default": "-1", "ignorable": true, + "about": "The generation of the group if the generic group protocol or the member epoch if the consumer protocol." }, Review Comment: How does the server decide to interpret this value as a GenerationId vs a MemberEpoch? Is it based on the API version used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
