[GitHub] [kafka] ning2008wisc commented on pull request #9215: KAFKA-10133: MM2 readme update on config

2020-09-04 Thread GitBox 


ning2008wisc commented on pull request #9215:
URL: https://github.com/apache/kafka/pull/9215#issuecomment-687328102


   Thanks @mimaison  for your prompt feedback



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ning2008wisc commented on pull request #9215: KAFKA-10133: MM2 readme update on config

2020-08-27 Thread GitBox 


ning2008wisc commented on pull request #9215:
URL: https://github.com/apache/kafka/pull/9215#issuecomment-682090080


   @mimaison thanks for your review. Regarding to your general comment about 
moving MM2 Readme to the Kafka documentation, I think it is a good idea to 
promote MM2 in the community. Do you suggest we will do this move in this PR or 
a follow-up PR after this one?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ning2008wisc commented on pull request #9215: KAFKA-10133: MM2 readme update on config

2020-08-24 Thread GitBox 


ning2008wisc commented on pull request #9215:
URL: https://github.com/apache/kafka/pull/9215#issuecomment-679420821


   Hi @ryannedolan @mimaison just in case I could borrow few minutes from you 
to take a quick review. Thanks 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org