[GitHub] [kafka] nizhikov commented on a diff in pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool
nizhikov commented on code in PR #12632: URL: https://github.com/apache/kafka/pull/12632#discussion_r970457373 ## core/src/main/scala/kafka/tools/StreamsResetter.java: ## @@ -213,8 +217,12 @@ private void parseArguments(final String[] args) { .ofType(String.class) .describedAs("id") .required(); -bootstrapServerOption = optionParser.accepts("bootstrap-servers", "Comma-separated list of broker urls with format: HOST1:PORT1,HOST2:PORT2") -.withRequiredArg() +bootstrapServerOption = optionParser.accepts("bootstrap-server", "The server(s) to use for bootstrapping.") Review Comment: Thanks for a hint. Apply code you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] nizhikov commented on a diff in pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool
nizhikov commented on code in PR #12632: URL: https://github.com/apache/kafka/pull/12632#discussion_r970460345 ## docs/streams/developer-guide/app-reset-tool.html: ## @@ -84,9 +84,11 @@ Step 1: Run the application reset tool
[GitHub] [kafka] nizhikov commented on a diff in pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool
nizhikov commented on code in PR #12632: URL: https://github.com/apache/kafka/pull/12632#discussion_r973021340 ## core/src/main/scala/kafka/tools/StreamsResetter.java: ## @@ -213,11 +217,16 @@ private void parseArguments(final String[] args) { .ofType(String.class) .describedAs("id") .required(); -bootstrapServerOption = optionParser.accepts("bootstrap-servers", "Comma-separated list of broker urls with format: HOST1:PORT1,HOST2:PORT2") -.withRequiredArg() +bootstrapServersOption = optionParser.accepts("bootstrap-servers", "DEPRECATED: Comma-separated list of broker urls with format: HOST1:PORT1,HOST2:PORT2") +.withOptionalArg() Review Comment: Logic changed to: ``` String bootstrapServerValue = BOOTSTRAP_SERVER_DEFAULT; if (options.has(bootstrapServerOption)) bootstrapServerValue = options.valueOf(bootstrapServerOption); else if (options.has(bootstrapServersOption)) bootstrapServerValue = options.valueOf(bootstrapServersOption); properties.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, bootstrapServerValue); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] nizhikov commented on a diff in pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool
nizhikov commented on code in PR #12632: URL: https://github.com/apache/kafka/pull/12632#discussion_r974176089 ## core/src/main/scala/kafka/tools/StreamsResetter.java: ## @@ -213,11 +217,16 @@ private void parseArguments(final String[] args) { .ofType(String.class) .describedAs("id") .required(); -bootstrapServerOption = optionParser.accepts("bootstrap-servers", "Comma-separated list of broker urls with format: HOST1:PORT1,HOST2:PORT2") -.withRequiredArg() +bootstrapServersOption = optionParser.accepts("bootstrap-servers", "DEPRECATED: Comma-separated list of broker urls with format: HOST1:PORT1,HOST2:PORT2") +.withOptionalArg() Review Comment: Thank. I changed code following your suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org