[GitHub] [kafka] nizhikov commented on pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool
nizhikov commented on PR #12632: URL: https://github.com/apache/kafka/pull/12632#issuecomment-1251318220 @C0urante Thank you very much) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] nizhikov commented on pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool
nizhikov commented on PR #12632: URL: https://github.com/apache/kafka/pull/12632#issuecomment-1251293104 @C0urante tests finished. It seems for me that failures unrelated but can you double check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] nizhikov commented on pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool
nizhikov commented on PR #12632: URL: https://github.com/apache/kafka/pull/12632#issuecomment-1249359020 Looks like system tests OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] nizhikov commented on pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool
nizhikov commented on PR #12632:
URL: https://github.com/apache/kafka/pull/12632#issuecomment-1249358441
```
docker exec ducker01 bash -c "cd /opt/kafka-dev && ducktape --cluster-file
/opt/kafka-dev/tests/docker/build/cluster.json
./tests/kafkatest/tests/streams/streams_optimized_test.py "
/usr/local/lib/python3.9/dist-packages/paramiko/transport.py:236:
CryptographyDeprecationWarning: Blowfish has been deprecated
"class": algorithms.Blowfish,
[INFO:2022-09-16 06:19:04,228]: starting test run with session id
2022-09-16--001...
[INFO:2022-09-16 06:19:04,228]: running 1 tests...
[INFO:2022-09-16 06:19:04,228]: Triggering test 1 of 1...
[INFO:2022-09-16 06:19:04,236]: RunnerClient: Loading test {'directory':
'/opt/kafka-dev/tests/kafkatest/tests/streams', 'file_name':
'streams_optimized_test.py', 'cls_name': 'StreamsOptimizedTest', 'method_name':
'test_upgrade_optimized_topology', 'injected_args': {'metadata_quorum':
'REMOTE_KRAFT'}}
[INFO:2022-09-16 06:19:04,239]: RunnerClient:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT:
on run 1/1
[INFO:2022-09-16 06:19:04,241]: RunnerClient:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT:
Setting up...
[INFO:2022-09-16 06:19:04,241]: RunnerClient:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT:
Running...
[INFO:2022-09-16 06:20:18,437]: RunnerClient:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT:
Tearing down...
[INFO:2022-09-16 06:20:24,849]: RunnerClient:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT:
PASS
[INFO:2022-09-16 06:20:24,849]: RunnerClient:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT:
Data: None
SESSION REPORT (ALL TESTS)
ducktape version: 0.11.1
session_id: 2022-09-16--001
run time: 1 minute 20.629 seconds
tests run:1
passed: 1
flaky:0
failed: 0
ignored: 0
test_id:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT
status: PASS
run time: 1 minute 20.610 seconds
nizhikov@kafka-test:~/kafka$ git status
On branch KAFKA-12878
nothing to commit, working tree clean
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] nizhikov commented on pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool
nizhikov commented on PR #12632: URL: https://github.com/apache/kafka/pull/12632#issuecomment-1249229645 @C0urante Thanks for the review. Fixed all your comments. Please, take a look one more time. > So we shouldn't have to worry about running these tests with a version of the CLI tools that doesn't recognize --bootstrap-server. Option name changed. I will try to setup ducktape tests environment and run the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] nizhikov commented on pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool
nizhikov commented on PR #12632: URL: https://github.com/apache/kafka/pull/12632#issuecomment-1247109394 I've checked tests failure. Looks like they are not related to the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] nizhikov commented on pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool
nizhikov commented on PR #12632: URL: https://github.com/apache/kafka/pull/12632#issuecomment-1246427376 @C0urante Thanks for the review. Fixed all your comments. > Should we also update the system test I doubt it. a. We have compatibility tests (which not use streams resetter at the moment). see - [streams_broker_compatibility_test.py](https://github.com/apache/kafka/blob/trunk/tests/kafkatest/tests/streams/streams_broker_compatibility_test.py#L82). So it's possible then in future we will try to use `kafka-streams-application-reset.sh` for previously released Kafka versions which knows nothing about new parameter. b. At the moment I don't have test environment to check changes in system tests :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
