[GitHub] [kafka] philipnee commented on pull request #13380: KAFKA-14468: Committed API
philipnee commented on PR #13380: URL: https://github.com/apache/kafka/pull/13380#issuecomment-1474404071 Hey @guozhangwang - I think i've addressed most of your questions except merging the request classes. It is a bit difficult right now as we sometimes need to access the fields before `UnsentRequest` is created. I've also updated the dedupcation before adding the commit - There are tests verifying the requests actually got purged upon completion I changed the naming of the methods and classes to make things more consistent. I've combined the request handler with the offset fetch request to make things cleaner. The Java exceptions, per your suggestions, are mapped to kafka exception. So the same set of exception will be thrown TODO: - Need to implement wakeup - Abstract some of ApplicationEvent to maybe something like CompletableEvent as some of them have a completableFuture embedded in it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] philipnee commented on pull request #13380: KAFKA-14468: Committed API
philipnee commented on PR #13380: URL: https://github.com/apache/kafka/pull/13380#issuecomment-1482045502 Hey @guozhangwang sorry for going back and forth on this, I'll add some test cases to cover your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] philipnee commented on pull request #13380: KAFKA-14468: Committed API
philipnee commented on PR #13380: URL: https://github.com/apache/kafka/pull/13380#issuecomment-1487707392 There's this weird failing test that I can't resolve. I think I might need to rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
