[GitHub] [kafka] philipnee commented on pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-06-02 Thread via GitHub 


philipnee commented on PR #13678:
URL: https://github.com/apache/kafka/pull/13678#issuecomment-1574015844

   The failures seem unrelated
   ```
   Build / JDK 8 and Scala 2.12 / 
testDescribeReportOverriddenConfigs(String).quorum=kraft – 
kafka.admin.TopicCommandIntegrationTest
   10s
   Build / JDK 8 and Scala 2.12 / testDelayedConfigurationOperations() – 
org.apache.kafka.controller.QuorumControllerTest
   <1s
   Build / JDK 11 and Scala 2.13 / testSyncTopicConfigs() – 
org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest
   1m 36s
   Build / JDK 11 and Scala 2.13 / testBalancePartitionLeaders() – 
org.apache.kafka.controller.QuorumControllerTest
   12s
   Build / JDK 11 and Scala 2.13 / testBalancePartitionLeaders() – 
org.apache.kafka.controller.QuorumControllerTest
   13s
   Fixed 68
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] philipnee commented on pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-05-22 Thread via GitHub 


philipnee commented on PR #13678:
URL: https://github.com/apache/kafka/pull/13678#issuecomment-1557511754

   @dajac - Would you have some time to review and help Erik to merge this? 
I've done a pass and I think it's okay.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] philipnee commented on pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-05-17 Thread via GitHub 


philipnee commented on PR #13678:
URL: https://github.com/apache/kafka/pull/13678#issuecomment-1551778364

   @erikvanoosten - Thanks for following up on this PR, I think we are really 
closed here.  Also apologize about the misleading comment.  I left a few 
comments above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org