[GitHub] [kafka] rhauch commented on pull request #8134: KAFKA-9546 Allow custom tasks through configuration

2020-09-29 Thread GitBox 


rhauch commented on pull request #8134:
URL: https://github.com/apache/kafka/pull/8134#issuecomment-700796780


   Thanks for the PR, @gcsaba2. However, I'm going to close this per my 
comments on https://issues.apache.org/jira/browse/KAFKA-9546. 
   
   TLDR; the `FileStreamSourceConnector` class is intentionally a simple 
example of a connector, and extending this as suggested makes that it harder to 
use and more error prone. Instead, just create your own connector with the 
desired functionality.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] rhauch commented on pull request #8134: KAFKA-9546 Allow custom tasks through configuration

2020-09-28 Thread GitBox 


rhauch commented on pull request #8134:
URL: https://github.com/apache/kafka/pull/8134#issuecomment-700351105


   As noted on https://issues.apache.org/jira/browse/KAFKA-9546, I'm not 
convinced this is useful change, since it would complicate these example 
connectors that ship with AK and would make customizing them very impractical 
from a build, release, and installation perspective.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org