[GitHub] [kafka] rhauch commented on pull request #9780: KAFKA-10021: Changed Kafka backing stores to use shared admin client to get end offsets and create topics

[GitBox]

rhauch commented on pull request #9780:
URL: https://github.com/apache/kafka/pull/9780#issuecomment-775505877


   Added another commit that uses Mockito in the new `SharedTopicAdminTest` 
class to do what @kkonstantine had suggested and which was not possible with 
EasyMock. 
   
   Mockito FTW!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] rhauch commented on pull request #9780: KAFKA-10021: Changed Kafka backing stores to use shared admin client to get end offsets and create topics

[GitBox]

rhauch commented on pull request #9780:
URL: https://github.com/apache/kafka/pull/9780#issuecomment-775330201


   Added a commit to incorporate @kkonstantine's suggestions (per thumbs-up 
above), and rebased to correct a merge conflict from `trunk`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] rhauch commented on pull request #9780: KAFKA-10021: Changed Kafka backing stores to use shared admin client to get end offsets and create topics

[GitBox]

rhauch commented on pull request #9780:
URL: https://github.com/apache/kafka/pull/9780#issuecomment-773485918


   Rebased on `trunk` to correct conflicts.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] rhauch commented on pull request #9780: KAFKA-10021: Changed Kafka backing stores to use shared admin client to get end offsets and create topics

[GitBox]

rhauch commented on pull request #9780:
URL: https://github.com/apache/kafka/pull/9780#issuecomment-773485918


   Rebased on `trunk` to correct conflicts.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] rhauch commented on pull request #9780: KAFKA-10021: Changed Kafka backing stores to use shared admin client to get end offsets and create topics

[GitBox]

rhauch commented on pull request #9780:
URL: https://github.com/apache/kafka/pull/9780#issuecomment-749845098


   Rebased on `trunk`, and then had to correct tests based on recent changes in 
Admin API related classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org