[GitHub] [kafka] rondagostino commented on pull request #10225: MINOR: fix security_test for ZK case due to error change

2021-03-08 Thread GitBox 


rondagostino commented on pull request #10225:
URL: https://github.com/apache/kafka/pull/10225#issuecomment-793057316


   Closed in favor of https://github.com/apache/kafka/pull/10240/



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] rondagostino commented on pull request #10225: MINOR: fix security_test for ZK case due to error change

2021-03-01 Thread GitBox 


rondagostino commented on pull request #10225:
URL: https://github.com/apache/kafka/pull/10225#issuecomment-788226851


   This PR "fixes" the issue by changing the system test to check for the new 
error.  We can close this PR in favor of another one if @abbccdda decides the 
behavior change is incorrect and can be corrected.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] rondagostino commented on pull request #10225: MINOR: fix security_test for ZK case due to error change

2021-03-01 Thread GitBox 


rondagostino commented on pull request #10225:
URL: https://github.com/apache/kafka/pull/10225#issuecomment-788225857


   https://issues.apache.org/jira/browse/KAFKA-12381



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] rondagostino commented on pull request #10225: MINOR: fix security_test for ZK case due to error change

2021-02-26 Thread GitBox 


rondagostino commented on pull request #10225:
URL: https://github.com/apache/kafka/pull/10225#issuecomment-786955706


   @abbccdda, @cmccabe.  Ported from #10199 to discuss separately.  We used to 
see this error message in `verifiable_producer.log` when 
`security_protocol='PLAINTEXT', interbroker_security_protocol='SSL'`:
   
   ```
   WARN [Producer clientId=producer-1] Error while fetching metadata with 
correlation id 1 : {test_topic=LEADER_NOT_AVAILABLE} 
(org.apache.kafka.clients.NetworkClient)
   ```
   The test does a `grep LEADER_NOT_AVAILABLE` on the log in this case, and it 
used to pass.
   
   Now we are instead seeing this in the log file:
   
   ```
   WARN [Producer clientId=producer-1] Error while fetching metadata with 
correlation id 1 : {test_topic=INVALID_REPLICATION_FACTOR} 
(org.apache.kafka.clients.NetworkClient)
   ```
   
   And of course now the test fails.
   
   The `INVALID_REPLICATION_FACTOR` is coming from the auto topic creation 
manager as I described above.
   
   It is a simple matter to make the test pass -- I have confirmed that it 
passes if we `grep` for `INVALID_REPLICATION_FACTOR` in the log file instead of 
`LEADER_NOT_AVAILABLE`.
   
   I think we just need to decide if this change in behavior is acceptable or 
not.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org