[GitHub] [kafka] rondagostino commented on pull request #10292: MINOR: fix client_compatibility_features_test.py
rondagostino commented on pull request #10292: URL: https://github.com/apache/kafka/pull/10292#issuecomment-800685338 > Can we just use a separate node for the client, unconditionally We don't have a `Service` for it, and we currently invoke it in a node that we allocate for the test. With no ZooKeeper all we have is Kafka (version >= 2.8, of course). I could see a situation where we add functionality to `org.apache.kafka.tools.ClientCompatibilityTest` in some future version and then we try to run that against Kafka v2.8 -- and then it'll go BOOM! as you suggest. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #10292: MINOR: fix client_compatibility_features_test.py
rondagostino commented on pull request #10292: URL: https://github.com/apache/kafka/pull/10292#issuecomment-800679385 > use the devel version of the tool when ZK is enabled, and the old version when it's not The code as amended in this PR will use the devel version when ZooKeeper is enabled (which is the way it always was except after I changed/broke it) and then, when Zookeeper is not enabled -- which is a new case -- it will use the Kafka version, which by definition will be >= 2.8. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #10292: MINOR: fix client_compatibility_features_test.py
rondagostino commented on pull request #10292: URL: https://github.com/apache/kafka/pull/10292#issuecomment-800644753 I broke this with https://github.com/apache/kafka/pull/10105/files#diff-84e14a0909d232b70f0a957ded161cd077d4dc1d069bbaab8e1bacc8dd2e0572L84-R85. The test used to always use the ZooKeeper node, and I changed it to use the Kafka node not realizing that the two distribution versions would be different. We want it to always use at least version 2.7, which we can get by using either the ZooKeeper node for the Zookeeper case or the Kafka node for the Raft case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #10292: MINOR: fix client_compatibility_features_test.py
rondagostino commented on pull request #10292: URL: https://github.com/apache/kafka/pull/10292#issuecomment-796970993 This needs to be cherry-picked to 2.8. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
