[GitHub] [kafka] rondagostino commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-20 Thread GitBox


rondagostino commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-677671036


   Actually, it turns out that the ability to use `kafka-configs 
--bootstrap-server` was only added in 2.5.  So this could be backported to 2.5 
and 2.6 (not all the way back to 2.2 as originally stated).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] rondagostino commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-19 Thread GitBox


rondagostino commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-676492765


   JDK 11 build failure was a n infrastructure issue.  JDK 8 test failure is an 
unrelated flaky test 
(`org.apache.kafka.streams.integration.EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState[exactly_once]`).
  JDK 14 build was clean.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] rondagostino commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-19 Thread GitBox


rondagostino commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-676491706


   Note that KIP-377 landed in 2.2 and explicitly stated in the new code that 
altering topic configurations via `kafka-topics` was deprecated – even using 
the `--zookeeper` flag (setting topic configs using `kafka-topics` when using 
`--create` to create a topic is supported and works with --bootstrap-server; 
it’s just altering/deleting topic configs that was deprecated via `--zookeeper` 
and that never worked/never will work via `--bootstrap-server`).  Therefore, 
potentially, this could be backported as far back as 2.2.x.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] rondagostino commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-18 Thread GitBox


rondagostino commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-675731352


   @cmccabe Can you take a look?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org