satishd commented on a change in pull request #9980: URL: https://github.com/apache/kafka/pull/9980#discussion_r565730154
########## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ########## @@ -63,7 +63,7 @@ private[log] object ProducerStateEntry { private[log] val NumBatchesToRetain = 5 def empty(producerId: Long) = new ProducerStateEntry(producerId, - batchMetadata = mutable.Queue[BatchMetadata](), + batchMetadata = new mutable.Queue[BatchMetadata](5), Review comment: minor: you may want to have it as `new mutable.Queue[BatchMetadata](NumBatchesToRetain)` instead of harcoding directly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org