[GitHub] [kafka] satishd commented on pull request #13309: MINOR Moved a few log segment util methods from LocalLog to LogFileUtils

2023-03-04 Thread via GitHub 


satishd commented on PR #13309:
URL: https://github.com/apache/kafka/pull/13309#issuecomment-1455007789

   > @satishd How is this related to moving `LogSegment`? It doesn't seem like 
that was updated at all?
   
   Methods like the below have usages in `LogSegment` class. Those will be 
updated as part of 
[KAFKA-14481](https://issues.apache.org/jira/browse/KAFKA-14481) changes. 
   
   ```
   UnifiedLog.offsetIndexFile(dir, baseOffset, fileSuffix)
   UnifiedLog.timeIndexFile(dir, baseOffset, fileSuffix)
   UnifiedLog.transactionIndexFile(dir, baseOffset, fileSuffix)
   UnifiedLog.logFile(dir, baseOffset, fileSuffix)
   ```
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] satishd commented on pull request #13309: MINOR Moved a few log segment util methods from LocalLog to LogFileUtils

2023-02-28 Thread via GitHub 


satishd commented on PR #13309:
URL: https://github.com/apache/kafka/pull/13309#issuecomment-1449372613

   Test failures do not seem to be related to this change, merging these 
changes to trunk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] satishd commented on pull request #13309: MINOR Moved a few log segment util methods from LocalLog to LogFileUtils

2023-02-28 Thread via GitHub 


satishd commented on PR #13309:
URL: https://github.com/apache/kafka/pull/13309#issuecomment-1448524298

   Thanks @junrao for the review. Addressed them with the latest 
commit/comments. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] satishd commented on pull request #13309: MINOR Moved a few log segment util methods from LocalLog to LogFileUtils

2023-02-26 Thread via GitHub 


satishd commented on PR #13309:
URL: https://github.com/apache/kafka/pull/13309#issuecomment-1445829945

   Thanks @showuon for the review. Addressed them with the latest commit. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org