[GitHub] [kafka] scanterog commented on pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-16 Thread GitBox 


scanterog commented on pull request #9313:
URL: https://github.com/apache/kafka/pull/9313#issuecomment-710022885


   > @scanterog I've rekicked the build
   
   I think this is ready to merge :P



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] scanterog commented on pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-15 Thread GitBox 


scanterog commented on pull request #9313:
URL: https://github.com/apache/kafka/pull/9313#issuecomment-709412233


   > Thanks @scanterog, the changes look good now. I've left a couple of very 
minor comments that would be nice to address. I'll be happy to merge then
   
   Thanks. There's one test failing for JDK15 apparently. Works locally with 
JDK11. I wish I could rerun those tests. Many flakeys ones.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] scanterog commented on pull request #9313: [mm2] Fix consumer/producer properties override

2020-09-25 Thread GitBox 


scanterog commented on pull request #9313:
URL: https://github.com/apache/kafka/pull/9313#issuecomment-698983392


   @mimaison just added it. Let me know if there's anything else to fix. Thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] scanterog commented on pull request #9313: [mm2] Fix consumer/producer properties override

2020-09-23 Thread GitBox 


scanterog commented on pull request #9313:
URL: https://github.com/apache/kafka/pull/9313#issuecomment-697968761


   @hachikuji is there any chance you can review this? Thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org