[GitHub] [kafka] scanterog commented on pull request #9545: [mm2] Allow Checkpoints for consumers using static partition assignments

2020-11-17 Thread GitBox 


scanterog commented on pull request #9545:
URL: https://github.com/apache/kafka/pull/9545#issuecomment-729110030


   @mimaison Not sure what we can test here. It is basically just allowing 
consumers with no members information (generally the case of consumer with 
static partition assignments) when discovering the available consumers. Happy 
to test what needs to be tested but I personally don't think we need a unit 
test for this. Happy to read on @ryannedolan's feedback too.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] scanterog commented on pull request #9545: [mm2] Allow Checkpoints for consumers using static partition assignments

2020-11-09 Thread GitBox 


scanterog commented on pull request #9545:
URL: https://github.com/apache/kafka/pull/9545#issuecomment-724379519


   > Groups created on the target cluster by KAFKA-9076 are "simple groups" as 
there's no member information.
   > Not entirely sure why these were explicitly filtered. I can't immediately 
come up with a reason.
   > 
   > @scanterog Can you add a test as well?
   
   Sure. Do we want a test for `findConsumerGroups` or what are you looking to 
test?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] scanterog commented on pull request #9545: [mm2] Allow Checkpoints for consumers using static partition assignments

2020-11-06 Thread GitBox 


scanterog commented on pull request #9545:
URL: https://github.com/apache/kafka/pull/9545#issuecomment-723063889


   @ryannedolan friendly ping. Would love your feedback on this one.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] scanterog commented on pull request #9545: [mm2] Allow Checkpoints for consumers using static partition assignments

2020-11-03 Thread GitBox 


scanterog commented on pull request #9545:
URL: https://github.com/apache/kafka/pull/9545#issuecomment-720844769


   cc: @ryannedolan who added this filter and might have more context on why 
this was needed.
   cc: @mimaison for more eyes on this :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org