[GitHub] [kafka] showuon commented on a change in pull request #9674: KAFKA-10665: close all kafkaStreams before purgeLocalStreamsState

[GitBox]

showuon commented on a change in pull request #9674:
URL: https://github.com/apache/kafka/pull/9674#discussion_r533956768



##
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinTopologyOptimizationIntegrationTest.java
##
@@ -221,7 +223,7 @@ private boolean topicExists(final String topic) {
 );
 }
 
-private  void validateReceivedMessages(final String topic,
+private  void validateMessagesReceived(final String topic,

Review comment:
   Rename the method name





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] showuon commented on a change in pull request #9674: KAFKA-10665: close all kafkaStreams before purgeLocalStreamsState

[GitBox]

showuon commented on a change in pull request #9674:
URL: https://github.com/apache/kafka/pull/9674#discussion_r533956676



##
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinTopologyOptimizationIntegrationTest.java
##
@@ -149,9 +153,7 @@ public void 
shouldDoStreamTableJoinWithDifferentNumberOfPartitions() throws Exce
 sendEvents(inputTopic, timestamp, expectedRecords);
 sendEvents(outputTopic, timestamp, expectedRecords);
 
-startStreams(streamsBuilder);

Review comment:
   I think we don't need to start 2 streams for this test





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org