[GitHub] [kafka] showuon commented on a diff in pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

[via GitHub]

showuon commented on code in PR #14151:
URL: https://github.com/apache/kafka/pull/14151#discussion_r1289945895


##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -913,6 +969,12 @@ private RemoteLogManagerConfig createRLMConfig(Properties 
props) {
 
props.put(RemoteLogManagerConfig.REMOTE_LOG_STORAGE_SYSTEM_ENABLE_PROP, true);
 
props.put(RemoteLogManagerConfig.REMOTE_STORAGE_MANAGER_CLASS_NAME_PROP, 
NoOpRemoteStorageManager.class.getName());
 
props.put(RemoteLogManagerConfig.REMOTE_LOG_METADATA_MANAGER_CLASS_NAME_PROP, 
NoOpRemoteLogMetadataManager.class.getName());
+props.put(REMOTE_LOG_METADATA_TOPIC_PARTITIONS_PROP, 
remoteLogMetadataTopicPartitionsNum);
+props.put(remoteLogMetadataTestProp, remoteLogMetadataTestVal);
+props.put(remoteLogMetadataCommonClientTestProp, 
remoteLogMetadataCommonClientTestVal);
+props.put(remoteLogMetadataConsumerTestProp, 
remoteLogMetadataConsumerTestVal);
+props.put(remoteLogMetadataProducerTestProp, 
remoteLogMetadataProducerTestVal);

Review Comment:
   I understand what you meant, I tried but that will bring the dependency with 
Storage module into client module, which is unexpected. I'm keeping it as is. 
Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] showuon commented on a diff in pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

[via GitHub]

showuon commented on code in PR #14151:
URL: https://github.com/apache/kafka/pull/14151#discussion_r1289944769


##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -134,6 +134,8 @@ public final class RemoteLogManagerConfig {
 "less than or equal to `log.retention.bytes` value.";
 public static final Long DEFAULT_LOG_LOCAL_RETENTION_BYTES = -2L;
 
+public static final String REMOTE_LOG_METADATA_PREFIX = 
"remote.log.metadata";

Review Comment:
   Thanks for the good suggestion! PR updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org