[GitHub] [kafka] showuon commented on pull request #10665: KAFKA-9009: increase replica.lag.time.max.ms to make the test reliable

2021-06-10 Thread GitBox 


showuon commented on pull request #10665:
URL: https://github.com/apache/kafka/pull/10665#issuecomment-858472811


   @mimaison , thanks for your time to review. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #10665: KAFKA-9009: increase replica.lag.time.max.ms to make the test reliable

2021-06-07 Thread GitBox 


showuon commented on pull request #10665:
URL: https://github.com/apache/kafka/pull/10665#issuecomment-856392681


   @mimaison , please help have a 2nd review. Thank you.
   
   The failed tests are unrelated and flaky.
   ```
   Build / JDK 15 and Scala 2.13 / 
kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
   Build / JDK 15 and Scala 2.13 / 
kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()
   Build / JDK 15 and Scala 2.13 / 
kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #10665: KAFKA-9009: increase replica.lag.time.max.ms to make the test reliable

2021-05-21 Thread GitBox 


showuon commented on pull request #10665:
URL: https://github.com/apache/kafka/pull/10665#issuecomment-845948314


   @mimaison , thanks for your comments. I've updated. Please take a look 
again. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #10665: KAFKA-9009: increase replica.lag.time.max.ms to make the test reliable

2021-05-17 Thread GitBox 


showuon commented on pull request #10665:
URL: https://github.com/apache/kafka/pull/10665#issuecomment-842772461


   @edoardocomar @mimaison  , could you help review this PR to make the test 
reliable. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #10665: KAFKA-9009: increase replica.lag.time.max.ms to make the test reliable

2021-05-11 Thread GitBox 


showuon commented on pull request #10665:
URL: https://github.com/apache/kafka/pull/10665#issuecomment-837956607


   Failed tests are un-related. Thanks.
   ```
   Build / JDK 15 and Scala 2.13 / 
org.apache.kafka.common.record.MemoryRecordsBuilderTest.[6] magic=2, 
bufferOffset=0, compressionType=GZIP
   Build / JDK 15 and Scala 2.13 / 
kafka.api.TransactionsBounceTest.testWithGroupMetadata()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #10665: KAFKA-9009: increase replica.lag.time.max.ms to make the test reliable

2021-05-10 Thread GitBox 


showuon commented on pull request #10665:
URL: https://github.com/apache/kafka/pull/10665#issuecomment-837734046


   @edoardocomar @mimaison , could you help review this PR to make the test 
reliable. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org