[GitHub] [kafka] showuon commented on pull request #11516: MINOR: Use MessageDigest equals when comparing signature

2022-09-14 Thread GitBox


showuon commented on PR #11516:
URL: https://github.com/apache/kafka/pull/11516#issuecomment-1246713341

   Failed tests are unrelated:
   ```
   Build / JDK 8 and Scala 2.12 / 
integration.kafka.server.FetchRequestBetweenDifferentIbpTest.testControllerNewToOldIBP()
   Build / JDK 17 and Scala 2.13 / 
kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, 
Name=testAllTopicPartition, Security=PLAINTEXT
   Build / JDK 17 and Scala 2.13 / 
kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testPathToJsonFile, 
Security=PLAINTEXT
   Build / JDK 17 and Scala 2.13 / 
kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testTopicPartition, 
Security=PLAINTEXT
   Build / JDK 17 and Scala 2.13 / 
kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, 
Name=testAllTopicPartition, Security=PLAINTEXT
   Build / JDK 17 and Scala 2.13 / 
kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testTopicPartition, 
Security=PLAINTEXT
   Build / JDK 17 and Scala 2.13 / kafka.server.ReplicaManagerTest.[1] 
usesTopicIds=true
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] showuon commented on pull request #11516: MINOR: Use MessageDigest equals when comparing signature

2022-09-05 Thread GitBox


showuon commented on PR #11516:
URL: https://github.com/apache/kafka/pull/11516#issuecomment-1237549764

   @rhauch , do you want to take a quick look for this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org