[GitHub] [kafka] showuon commented on pull request #12748: KAFKA-13715: add generationId field in subscription
showuon commented on PR #12748: URL: https://github.com/apache/kafka/pull/12748#issuecomment-1333272289 All tests passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12748: KAFKA-13715: add generationId field in subscription
showuon commented on PR #12748: URL: https://github.com/apache/kafka/pull/12748#issuecomment-1331732502 @dajac , Thanks for the comments. PR updated. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12748: KAFKA-13715: add generationId field in subscription
showuon commented on PR #12748: URL: https://github.com/apache/kafka/pull/12748#issuecomment-1327047070 @dajac , thanks for the comment. And thanks to the test, I found there's one thing I missed, which is in eager rebalance protocol like StickyAssignor, the ownedPartitions will all get revoked before joining group. And that means, we have to rely on userData in StickyAssignor. I've updated the `memberDataFromSubscription` for it. Please check the latest commit: https://github.com/apache/kafka/pull/12748/commits/6081deedcf2591d407cde8fe6cc5d6dd12875fcb . Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12748: KAFKA-13715: add generationId field in subscription
showuon commented on PR #12748: URL: https://github.com/apache/kafka/pull/12748#issuecomment-1318195383 @dajac , thanks for the comments. PR updated. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12748: KAFKA-13715: add generationId field in subscription
showuon commented on PR #12748: URL: https://github.com/apache/kafka/pull/12748#issuecomment-1310065769 @dajac , PR updated. Please take a look when available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12748: KAFKA-13715: add generationId field in subscription
showuon commented on PR #12748: URL: https://github.com/apache/kafka/pull/12748#issuecomment-1308231893 @dajac , I've addressed all comments. Please take a look when available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12748: KAFKA-13715: add generationId field in subscription
showuon commented on PR #12748: URL: https://github.com/apache/kafka/pull/12748#issuecomment-1296682750 @dajac @guozhangwang , call for review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12748: KAFKA-13715: add generationId field in subscription
showuon commented on PR #12748: URL: https://github.com/apache/kafka/pull/12748#issuecomment-1283533387 @dajac , sorry for delay. It's good for review now. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
