[GitHub] [kafka] showuon commented on pull request #14347: KAFKA-15439: Transactions test with tiered storage

2023-09-13 Thread via GitHub


showuon commented on PR #14347:
URL: https://github.com/apache/kafka/pull/14347#issuecomment-1718626560

   Backported to 3.6 branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] showuon commented on pull request #14347: KAFKA-15439: Transactions test with tiered storage

2023-09-13 Thread via GitHub


showuon commented on PR #14347:
URL: https://github.com/apache/kafka/pull/14347#issuecomment-1718624599

   Failed tests are unrelated:
   ```
   Build / JDK 20 and Scala 2.13 / 
org.apache.kafka.common.security.authenticator.SaslAuthenticatorFailurePositiveDelayTest.testInvalidPasswordSaslPlain()
   Build / JDK 20 and Scala 2.13 / 
org.apache.kafka.streams.processor.internals.assignment.StickyTaskAssignorTest.shouldAssignRandomInput[enableRackAwareTaskAssignor=true]
   Build / JDK 11 and Scala 2.13 / 
org.apache.kafka.tiered.storage.integration.TransactionsWithTieredStoreTest.testFencingOnSend(String).quorum=zk
   Build / JDK 11 and Scala 2.13 / 
org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
   Build / JDK 8 and Scala 2.12 / 
kafka.api.DelegationTokenEndToEndAuthorizationWithOwnerTest.testDescribeTokenForOtherUserPasses(String).quorum=kraft
   Build / JDK 17 and Scala 2.13 / 
integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor()
   Build / JDK 17 and Scala 2.13 / 
kafka.admin.DeleteConsumerGroupsTest.testDeleteCmdNonEmptyGroup(String).quorum=kraft
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] showuon commented on pull request #14347: KAFKA-15439: Transactions test with tiered storage

2023-09-13 Thread via GitHub


showuon commented on PR #14347:
URL: https://github.com/apache/kafka/pull/14347#issuecomment-1717376584

   Opened https://github.com/kamalcph/kafka/pull/2 to make the tests pass. 
Trying to run in this PR first: https://github.com/apache/kafka/pull/14383 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] showuon commented on pull request #14347: KAFKA-15439: Transactions test with tiered storage

2023-09-13 Thread via GitHub


showuon commented on PR #14347:
URL: https://github.com/apache/kafka/pull/14347#issuecomment-1717240274

   Will look into it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] showuon commented on pull request #14347: KAFKA-15439: Transactions test with tiered storage

2023-09-12 Thread via GitHub


showuon commented on PR #14347:
URL: https://github.com/apache/kafka/pull/14347#issuecomment-1715593134

   @kamalcph , I can't successfully commit into your branch with permission 
error. Anyway, I've opened a PR against your branch: 
https://github.com/kamalcph/kafka/pull/1 . I've tested in my env and it passes 
all tests in `TransactionsWithTieredStoreTest`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] showuon commented on pull request #14347: KAFKA-15439: Transactions test with tiered storage

2023-09-11 Thread via GitHub


showuon commented on PR #14347:
URL: https://github.com/apache/kafka/pull/14347#issuecomment-1714835205

   @kamalcph , there's a compile error. Please help fix it. Thanks.
   
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14347/9/pipeline


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] showuon commented on pull request #14347: KAFKA-15439: Transactions test with tiered storage

2023-09-11 Thread via GitHub


showuon commented on PR #14347:
URL: https://github.com/apache/kafka/pull/14347#issuecomment-1713489561

   @kamalcph , I'll work on the fix for 
`TransactionsTest.testFencingOnTransactionExpiration`. You can focus on the PR. 
FYI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] showuon commented on pull request #14347: KAFKA-15439: Transactions test with tiered storage

2023-09-11 Thread via GitHub


showuon commented on PR #14347:
URL: https://github.com/apache/kafka/pull/14347#issuecomment-1713298394

   Compile error happened. Please check. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org