[GitHub] [kafka] showuon edited a comment on pull request #10736: KAFKA-9295: increase session timeout to 30 seconds

2021-05-28 Thread GitBox


showuon edited a comment on pull request #10736:
URL: https://github.com/apache/kafka/pull/10736#issuecomment-850396020


   OK, on second thought, I start to think the root cause of this flaky test is 
because the bug mentioned above. Increasing session timeout is just a 
workaround to avoid rebalancing caused data lost. I'll look into it further, 
and file a bug then. Any suggestions are welcomed. 
   Before the root cause got fixed, I think we can workaround it by increasing 
more session timeout. What do you think?
   Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] showuon edited a comment on pull request #10736: KAFKA-9295: increase session timeout to 30 seconds

2021-05-27 Thread GitBox


showuon edited a comment on pull request #10736:
URL: https://github.com/apache/kafka/pull/10736#issuecomment-850119016


   1 more thing to add, because I can still see heartbeat expiration after 
increasing to 20 seconds:
   ```
   reason: removing member 
KTable-FKJ-Multi-98311d03-31f2-4b20-bfcf-0cfc516741f5-StreamThread-1-consumer-06247087-0bc9-4f74-b0a4-a617c638e427
 on heartbeat expiration
   ```
   So, the session timeout increasing to 30 sec is to avoid this unexpected 
rebalancing happen, to make the test reliable. I think it makes sense. Just 
concerning the data lost issue mentioned above. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org