[GitHub] [kafka] soarez commented on pull request #12314: KAFKA-13903: Queue size metric in QuorumController
soarez commented on PR #12314: URL: https://github.com/apache/kafka/pull/12314#issuecomment-1280064868 Rebased and simplified the changes. PTAL @mumrah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] soarez commented on pull request #12314: KAFKA-13903: Queue size metric in QuorumController
soarez commented on PR #12314: URL: https://github.com/apache/kafka/pull/12314#issuecomment-1160920644 Hi Divij, thanks for having a look at this. The metric [is documented](https://github.com/apache/kafka/blob/89c057397ec5ae320aee7e12e1a984b2c14a7fa5/docs/ops.html#L1424-L1428). The goal is to bring it to KRaft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] soarez commented on pull request #12314: KAFKA-13903: Queue size metric in QuorumController
soarez commented on PR #12314: URL: https://github.com/apache/kafka/pull/12314#issuecomment-1181806166 @mumrah could you review this PR? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] soarez commented on pull request #12314: KAFKA-13903: Queue size metric in QuorumController
soarez commented on PR #12314: URL: https://github.com/apache/kafka/pull/12314#issuecomment-1185293934 Thanks for the review @mumrah. I've applied your suggestion. It feels a bit strange to have the queue size supplier as an argument in `QuorumControllerMetrics`, but I like that the field is now `final`. Please have another look 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] soarez commented on pull request #12314: KAFKA-13903: Queue size metric in QuorumController
soarez commented on PR #12314: URL: https://github.com/apache/kafka/pull/12314#issuecomment-1191462380 @mumrah a couple of the builds succeeded but some failed with a flaky test — `testFencedLeaderRecovery`. There is already a JIRA for it https://issues.apache.org/jira/browse/KAFKA-14093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] soarez commented on pull request #12314: KAFKA-13903: Queue size metric in QuorumController
soarez commented on PR #12314: URL: https://github.com/apache/kafka/pull/12314#issuecomment-1195483345 @mumrah could you take another look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
