[GitHub] [kafka] stanislavkozlovski commented on pull request #7498: KAFKA-9023: Log request destination when the Producer gets disconnected

2020-11-12 Thread GitBox 


stanislavkozlovski commented on pull request #7498:
URL: https://github.com/apache/kafka/pull/7498#issuecomment-726079643


   test failures for JDK 15 seem unrelated:
   ```
   kafka.server.ScramServerStartupTest.testAuthentications
   org.apache.zookeeper.KeeperException$NoAuthException: KeeperErrorCode = 
NoAuth for /config/changes
   
   
org.apache.kafka.streams.integration.StreamTableJoinTopologyOptimizationIntegrationTest.shouldDoStreamTableJoinWithDifferentNumberOfPartitions[Optimization
 = none]
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] stanislavkozlovski commented on pull request #7498: KAFKA-9023: Log request destination when the Producer gets disconnected

2020-11-09 Thread GitBox 


stanislavkozlovski commented on pull request #7498:
URL: https://github.com/apache/kafka/pull/7498#issuecomment-724117161


   >  guess this is a nitpick, but I'd rather not construct an error message 
when I might or might not need it (and won't in the common, error-free case.)
   
   @cmccabe we construct it only when the error message is not null and not 
empty
   
   cc @dajac could you help review this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org