[GitHub] [kafka] tinaselenge commented on a diff in pull request #13660: KAFKA-14662: Update the ACL list in the doc
tinaselenge commented on code in PR #13660: URL: https://github.com/apache/kafka/pull/13660#discussion_r1183526354 ## docs/security.html: ## @@ -2089,6 +2089,144 @@ https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java#L101). However now looking at the code again, I don't think ClusterAction operation is checked as part of the authorization check for them but used later for throttling the requests. So I think I should remove them, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] tinaselenge commented on a diff in pull request #13660: KAFKA-14662: Update the ACL list in the doc
tinaselenge commented on code in PR #13660: URL: https://github.com/apache/kafka/pull/13660#discussion_r1183527261 ## docs/security.html: ## @@ -2089,6 +2089,144 @@
[GitHub] [kafka] tinaselenge commented on a diff in pull request #13660: KAFKA-14662: Update the ACL list in the doc
tinaselenge commented on code in PR #13660: URL: https://github.com/apache/kafka/pull/13660#discussion_r1183526354 ## docs/security.html: ## @@ -2089,6 +2089,144 @@ https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java#L101). However now looking at them again, I'm not sure where ClusterAction operation is checked for them. I only see Describe or Alter operations being checked on Cluster resource. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org