[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1441516170 Tests have passed for one of the builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1441214746 Thanks Michael. I added a happy path testcase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1437369614 Thanks @mimaison . I addressed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1433009209 Tests passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1432614316
@fvaleri , I fixed the above error. Some of the containers had died because
of which the error occurred. I have a clean run of the system test now:
```
SESSION REPORT (ALL TESTS)
ducktape version: 0.11.3
session_id: 2023-02-15--005
run time: 7 minutes 46.389 seconds
tests run:7
passed: 7
flaky:0
failed: 0
ignored: 0
test_id:
kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=0.8.2.2.new_consumer=False
status: PASS
run time: 56.724 seconds
{"producer_performance": {"records_per_sec": 17123.287671, "mb_per_sec":
1.63}, "end_to_end_latency": {"latency_50th_ms": 1.0, "latency_99th_ms": 5.0,
"latency_999th_ms": 16.0}, "consumer_performance": {"records_per_sec":
1428571.4286, "mb_per_sec": 136.2392}}
test_id:
kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=0.9.0.1
status: PASS
run time: 1 minute 7.159 seconds
{"producer_performance": {"records_per_sec": 10152.284264, "mb_per_sec":
0.97}, "end_to_end_latency": {"latency_50th_ms": 1.0, "latency_99th_ms": 10.0,
"latency_999th_ms": 23.0}, "consumer_performance": {"records_per_sec":
62305.296, "mb_per_sec": 3.5948}}
test_id:
kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=0.9.0.1.new_consumer=False
status: PASS
run time: 58.971 seconds
{"producer_performance": {"records_per_sec": 13262.599469, "mb_per_sec":
1.26}, "end_to_end_latency": {"latency_50th_ms": 1.0, "latency_99th_ms": 9.0,
"latency_999th_ms": 23.0}, "consumer_performance": {"records_per_sec":
1428571.4286, "mb_per_sec": 136.2392}}
test_id:
kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=1.1.1.new_consumer=False
status: PASS
run time: 1 minute 6.057 seconds
{"producer_performance": {"records_per_sec": 11350.737798, "mb_per_sec":
1.08}, "end_to_end_latency": {"latency_50th_ms": 2.0, "latency_99th_ms": 10.0,
"latency_999th_ms": 21.0}, "consumer_performance": {"records_per_sec":
166.6667, "mb_per_sec": 158.9457}}
test_id:
kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=dev.metadata_quorum=COLOCATED_KRAFT
status: PASS
run time: 1 minute 8.146 seconds
{"producer_performance": {"records_per_sec": 4918.839154, "mb_per_sec":
0.47}, "end_to_end_latency": {"latency_50th_ms": 2.0, "latency_99th_ms": 12.0,
"latency_999th_ms": 34.0}, "consumer_performance": {"records_per_sec":
12199.5134, "mb_per_sec": 1.1609}}
test_id:
kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=dev.metadata_quorum=REMOTE_KRAFT
status: PASS
run time: 1 minute 16.390 seconds
{"producer_performance": {"records_per_sec": 11520.737327, "mb_per_sec":
1.1}, "end_to_end_latency": {"latency_50th_ms": 2.0, "latency_99th_ms": 13.0,
"latency_999th_ms": 42.0}, "consumer_performance": {"records_per_sec":
11722.807, "mb_per_sec": 1.1159}}
test_id:
kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=dev.metadata_quorum=ZK
status: PASS
run time: 1 minute 12.011 seconds
{"producer_performance": {"records_per_sec": 7547.169811, "mb_per_sec":
0.72}, "end_to_end_latency": {"latency_50th_ms": 2.0, "latency_99th_ms": 13.0,
"latency_999th_ms": 29.0}, "consumer_performance": {"records_per_sec":
11990.8362, "mb_per_sec": 1.1031}}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1427752677
Thanks @fvaleri for pointing me to the fix you made for JMXTool issue. I
made the changes to also look into version when choosing the EndToEndLatency
class.
I did point out the usage of TestEndToEndLatency
[here](https://github.com/apache/kafka/pull/13095#issuecomment-1407268172) but
I don't have context here. Also, when I try to run
`kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version`,
I get this:
```
[INFO:2023-02-13 03:03:31,147]: RunnerClient:
kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=dev.metadata_quorum=ZK:
FAIL: gaierror(-2, 'Name or service not known')
Traceback (most recent call last):
File
"/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line
185, in _do_run
self.setup_test()
File
"/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line
237, in setup_test
self.test.setup()
File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/test.py", line
74, in setup
self.setUp()
File
"/opt/kafka-dev/tests/kafkatest/sanity_checks/test_performance_services.py",
line 38, in setUp
self.zk.start()
File
"/usr/local/lib/python3.9/dist-packages/ducktape/services/service.py", line
265, in start
self.start_node(node, **kwargs)
File "/opt/kafka-dev/tests/kafkatest/services/zookeeper.py", line 95, in
start_node
node.account.ssh("mkdir -p %s" % ZookeeperService.DATA)
File
"/usr/local/lib/python3.9/dist-packages/ducktape/cluster/remoteaccount.py",
line 35, in wrapper
return method(self, *args, **kwargs)
File
"/usr/local/lib/python3.9/dist-packages/ducktape/cluster/remoteaccount.py",
line 300, in ssh
client = self.ssh_client
File
"/usr/local/lib/python3.9/dist-packages/ducktape/cluster/remoteaccount.py",
line 215, in ssh_client
self._set_ssh_client()
File
"/usr/local/lib/python3.9/dist-packages/ducktape/cluster/remoteaccount.py",
line 35, in wrapper
return method(self, *args, **kwargs)
File
"/usr/local/lib/python3.9/dist-packages/ducktape/cluster/remoteaccount.py",
line 189, in _set_ssh_client
client.connect(
File "/usr/local/lib/python3.9/dist-packages/paramiko/client.py", line
340, in connect
to_try = list(self._families_and_addresses(hostname, port))
File "/usr/local/lib/python3.9/dist-packages/paramiko/client.py", line
203, in _families_and_addresses
addrinfos = socket.getaddrinfo(
File "/usr/lib/python3.9/socket.py", line 953, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -2] Name or service not known
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1426985065
@fvaleri , @mimaison here's a sample run from my local setup :
```
(ducktape) sarao@C02GG1KCML7H kafka %
TC_PATHS="tests/kafkatest/benchmarks/core/benchmark_test.py::Benchmark.test_end_to_end_latency"
bash tests/docker/run_tests.sh
> Configure project :
Starting build with version 3.5.0-SNAPSHOT (commit id 4ecc30e0) using Gradle
7.6, Java 1.8 and Scala 2.13.10
Build properties: maxParallelForks=8, maxScalacThreads=8, maxTestRetries=0
BUILD SUCCESSFUL in 10s
170 actionable tasks: 170 up-to-date
docker exec ducker01 bash -c "cd /opt/kafka-dev && ducktape --cluster-file
/opt/kafka-dev/tests/docker/build/cluster.json
./tests/kafkatest/benchmarks/core/benchmark_test.py::Benchmark.test_end_to_end_latency
"
/usr/local/lib/python3.9/dist-packages/paramiko/transport.py:236:
CryptographyDeprecationWarning: Blowfish has been deprecated
"class": algorithms.Blowfish,
[INFO:2023-02-12 00:59:22,204]: starting test run with session id
2023-02-12--002...
[INFO:2023-02-12 00:59:22,206]: running 10 tests...
[INFO:2023-02-12 00:59:22,208]: Triggering test 1 of 10...
[INFO:2023-02-12 00:59:22,271]: RunnerClient: Loading test {'directory':
'/opt/kafka-dev/tests/kafkatest/benchmarks/core', 'file_name':
'benchmark_test.py', 'cls_name': 'Benchmark', 'method_name':
'test_end_to_end_latency', 'injected_args': {'security_protocol':
'SASL_PLAINTEXT', 'compression_type': 'none'}}
[INFO:2023-02-12 00:59:22,300]: RunnerClient:
kafkatest.benchmarks.core.benchmark_test.Benchmark.test_end_to_end_latency.security_protocol=SASL_PLAINTEXT.compression_type=none:
on run 1/1
[INFO:2023-02-12 00:59:22,321]: RunnerClient:
kafkatest.benchmarks.core.benchmark_test.Benchmark.test_end_to_end_latency.security_protocol=SASL_PLAINTEXT.compression_type=none:
Setting up...
[INFO:2023-02-12 00:59:27,898]: RunnerClient:
kafkatest.benchmarks.core.benchmark_test.Benchmark.test_end_to_end_latency.security_protocol=SASL_PLAINTEXT.compression_type=none:
Running...
[INFO:2023-02-12 01:03:02,248]: RunnerClient:
kafkatest.benchmarks.core.benchmark_test.Benchmark.test_end_to_end_latency.security_protocol=SASL_PLAINTEXT.compression_type=none:
Tearing down...
[INFO:2023-02-12 01:03:34,257]: RunnerClient:
kafkatest.benchmarks.core.benchmark_test.Benchmark.test_end_to_end_latency.security_protocol=SASL_PLAINTEXT.compression_type=none:
PASS
[INFO:2023-02-12 01:03:34,263]: RunnerClient:
kafkatest.benchmarks.core.benchmark_test.Benchmark.test_end_to_end_latency.security_protocol=SASL_PLAINTEXT.compression_type=none:
Data: {'latency_50th_ms': 7.0, 'latency_99th_ms': 47.0, 'latency_999th_ms':
169.0}
[INFO:2023-02-12 01:03:34,347]:
~
[INFO:2023-02-12 01:03:34,350]: Triggering test 2 of 10...
[INFO:2023-02-12 01:03:34,399]: RunnerClient: Loading test {'directory':
'/opt/kafka-dev/tests/kafkatest/benchmarks/core', 'file_name':
'benchmark_test.py', 'cls_name': 'Benchmark', 'method_name':
'test_end_to_end_latency', 'injected_args': {'security_protocol':
'SASL_PLAINTEXT', 'compression_type': 'snappy'}}
[INFO:2023-02-12 01:03:34,434]: RunnerClient:
kafkatest.benchmarks.core.benchmark_test.Benchmark.test_end_to_end_latency.security_protocol=SASL_PLAINTEXT.compression_type=snappy:
on run 1/1
[INFO:2023-02-12 01:03:34,446]: RunnerClient:
kafkatest.benchmarks.core.benchmark_test.Benchmark.test_end_to_end_latency.security_protocol=SASL_PLAINTEXT.compression_type=snappy:
Setting up...
[INFO:2023-02-12 01:03:47,646]: RunnerClient:
kafkatest.benchmarks.core.benchmark_test.Benchmark.test_end_to_end_latency.security_protocol=SASL_PLAINTEXT.compression_type=snappy:
Running...
[INFO:2023-02-12 01:07:06,578]: RunnerClient:
kafkatest.benchmarks.core.benchmark_test.Benchmark.test_end_to_end_latency.security_protocol=SASL_PLAINTEXT.compression_type=snappy:
Tearing down...
[INFO:2023-02-12 01:07:34,367]: RunnerClient:
kafkatest.benchmarks.core.benchmark_test.Benchmark.test_end_to_end_latency.security_protocol=SASL_PLAINTEXT.compression_type=snappy:
PASS
[INFO:2023-02-12 01:07:34,372]: RunnerClient:
kafkatest.benchmarks.core.benchmark_test.Benchmark.test_end_to_end_latency.security_protocol=SASL_PLAINTEXT.compression_type=snappy:
Data: {'latency_50th_ms': 9.0, 'latency_99th_ms': 50.0, 'latency_999th_ms':
131.0}
[INFO:2023-02-12 01:07:34,442]:
~
[INFO:2023-02-12 01:07:34,445]: Triggering test 3 of 10...
[INFO:2023-02-12 01:07:34,485]: RunnerClient: Loading test {'directory':
'/opt/kafka-dev/tests/kafkatest/benchmarks/core', 'file_name':
'benchmark_test.py', 'cls_name': 'Benchmark', 'method_name':
'test_end_to_end_latency', 'injected_args': {'security_protocol': 'SASL_SSL',
'compression_type': 'none'}}
[INFO:2023-02-12 01:07:34,
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-141003 @mimaison , I updated the system test to point to the new class. That one place seemed to be the only one relevant in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1408469183 > I simply meant that it looks like some changes in the system tests are required too. Got it. Thanks for the confirmation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1407268172 > EndToEndLatencyService Thanks @mimaison . Actually I lack some context here. The class, `TestEndToEndLatency` was renamed to `EndToEndLatency` with this very old PR: https://github.com/apache/kafka/commit/e43c9aff92c57da6abb0c1d0af3431a550110a89#diff-52dbfa7ab683a53b91a84c35f309b56ff1b2a1cd94e4ccb86c5843e9e44a050f and in a subsequent PR, the support for zk_connect was removed. So, the line you highlighted above mayn't need to be changed. Also, there's no reference of `TestEndToEndLatency` in the project anymore in trunk so I am assuming it would be shipped with older version (< 0.9) maybe? Were you referring to this line instead? https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/performance/end_to_end_latency.py#L127 which is invoked on line #91? I agree, that needs to be changed. Plz let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1405382219 > Sorry for the delay. Thanks for the PR, I left a few minor suggestions. No problem! I addressed the comments. Thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1404639472 hi @mimaison would you plz review this PR whenever you get the chance? It's already approved by @fvaleri . Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1387172335 > Builds on 8 and 17 are ok. Test failure on 11 is unrelated and it works fine on my machine. > > Thanks. Thanks @fvaleri . @mimaison would you be able to take a look as well? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1383408137 @fvaleri , thanks. I made the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1383104841 @fvaleri , i removed the code changes related to argparse4j. That way the interface of the tool is exactly similar to what it was previously. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1382883307 https://github.com/apache/kafka/pull/13095#discussion_r1069689088 I looked at other classes in tool and saw arg4jparse being used in them and assumed that this is the direction that has been chosen. Is that not the case? In that case I can revert to using args. Plz let me know -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1381703690 Looks like there are some more checkstyle failures. Will fix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1381690612 hi @mimaison , I added a few basic unit tests and updated the system test needs (end_to_end_latency.py). I haven't set it up locally but I am hoping those should run from here to validate if the changes worked. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1375924994 Actually i pinged too soon :) Before getting it reviewed, I would test on my local and also add a couple of tests. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1375755934 @ijuma , I made the changes, but I couldn't find any tests associated with the scala class. Wanted to know how can I test this . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
