[GitHub] [kafka] vamossagar12 commented on pull request #13127: KAFKA-14586: Moving StreamResetter to tools
vamossagar12 commented on PR #13127: URL: https://github.com/apache/kafka/pull/13127#issuecomment-1456365306 @cadonna , bumping this one again :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13127: KAFKA-14586: Moving StreamResetter to tools
vamossagar12 commented on PR #13127: URL: https://github.com/apache/kafka/pull/13127#issuecomment-1441515595 Thanks @fvaleri ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13127: KAFKA-14586: Moving StreamResetter to tools
vamossagar12 commented on PR #13127: URL: https://github.com/apache/kafka/pull/13127#issuecomment-1437373209 > > Regarding moving to CommandDefaultOptions, is it better if we do it in a follow up PR as that is not directly connected to migrating to tools module. > > Hi @vamossagar12, I'm ok with doing it in a follow up PR. Do we have a Jira for that? Thanks @fvaleri , here you go: https://issues.apache.org/jira/browse/KAFKA-14734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13127: KAFKA-14586: Moving StreamResetter to tools
vamossagar12 commented on PR #13127: URL: https://github.com/apache/kafka/pull/13127#issuecomment-1427653494 Thanks for the review @fvaleri . I addressed/responded to the comments. Regarding moving to `CommandDefaultOptions`, is it better if we do it in a follow up PR as that is not directly connected to migrating to tools module. I am not saying it isn't important but trying to keep the scope of this PR limited to the migration since StreamsResetter has been working this way since the beginning. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13127: KAFKA-14586: Moving StreamResetter to tools
vamossagar12 commented on PR #13127: URL: https://github.com/apache/kafka/pull/13127#issuecomment-1425650698 Tests seemed to have passed for one of the builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13127: KAFKA-14586: Moving StreamResetter to tools
vamossagar12 commented on PR #13127:
URL: https://github.com/apache/kafka/pull/13127#issuecomment-1425469233
@cadonna , @fvaleri I ran the system test for StreamsResetter from my local
(and fixed the checkstyle). The tests are running, would keep an eye on it =>
```
./gradlew clean systemTestLibs
> Configure project :
Starting build with version 3.5.0-SNAPSHOT (commit id af3bedfd) using Gradle
7.6, Java 1.8 and Scala 2.13.10
Build properties: maxParallelForks=8, maxScalacThreads=8, maxTestRetries=0
BUILD SUCCESSFUL in 5m 44s
220 actionable tasks: 212 executed, 8 up-to-date
(ducktape) sarao@C02GG1KCML7H kafka %
TC_PATHS="tests/kafkatest/tests/streams/streams_optimized_test.py::StreamsOptimizedTest"
bash tests/docker/run_tests.sh
> Configure project :
Starting build with version 3.5.0-SNAPSHOT (commit id af3bedfd) using Gradle
7.6, Java 1.8 and Scala 2.13.10
Build properties: maxParallelForks=8, maxScalacThreads=8, maxTestRetries=0
BUILD SUCCESSFUL in 9s
172 actionable tasks: 172 up-to-date
docker exec ducker01 bash -c "cd /opt/kafka-dev && ducktape --cluster-file
/opt/kafka-dev/tests/docker/build/cluster.json
./tests/kafkatest/tests/streams/streams_optimized_test.py::StreamsOptimizedTest
"
/usr/local/lib/python3.9/dist-packages/paramiko/transport.py:236:
CryptographyDeprecationWarning: Blowfish has been deprecated
"class": algorithms.Blowfish,
[INFO:2023-02-10 01:05:18,393]: starting test run with session id
2023-02-10--002...
[INFO:2023-02-10 01:05:18,395]: running 1 tests...
[INFO:2023-02-10 01:05:18,398]: Triggering test 1 of 1...
[INFO:2023-02-10 01:05:18,454]: RunnerClient: Loading test {'directory':
'/opt/kafka-dev/tests/kafkatest/tests/streams', 'file_name':
'streams_optimized_test.py', 'cls_name': 'StreamsOptimizedTest', 'method_name':
'test_upgrade_optimized_topology', 'injected_args': {'metadata_quorum':
'REMOTE_KRAFT'}}
[INFO:2023-02-10 01:05:18,480]: RunnerClient:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT:
on run 1/1
[INFO:2023-02-10 01:05:18,498]: RunnerClient:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT:
Setting up...
[INFO:2023-02-10 01:05:18,503]: RunnerClient:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT:
Running...
[INFO:2023-02-10 01:08:00,049]: RunnerClient:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT:
Tearing down...
[INFO:2023-02-10 01:08:26,433]: RunnerClient:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT:
PASS
[INFO:2023-02-10 01:08:26,437]: RunnerClient:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT:
Data: None
SESSION REPORT (ALL TESTS)
ducktape version: 0.11.3
session_id: 2023-02-10--002
run time: 3 minutes 8.101 seconds
tests run:1
passed: 1
flaky:0
failed: 0
ignored: 0
test_id:
kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=REMOTE_KRAFT
status: PASS
run time: 3 minutes 7.954 seconds
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13127: KAFKA-14586: Moving StreamResetter to tools
vamossagar12 commented on PR #13127: URL: https://github.com/apache/kafka/pull/13127#issuecomment-1423890722 Thanks @cadonna , would do the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13127: KAFKA-14586: Moving StreamResetter to tools
vamossagar12 commented on PR #13127: URL: https://github.com/apache/kafka/pull/13127#issuecomment-1422825052 > @vamossagar12 as you can see from the CI output, there are checkstyle errors. Have you tried to run at least one of the system tests that are using the tool? hi @fvaleri , yes I am aware of the checkstyle issue and pointed it out here: https://github.com/apache/kafka/pull/13127#issuecomment-1396439952. I have run the StreamResetter tests and also modified the system test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13127: KAFKA-14586: Moving StreamResetter to tools
vamossagar12 commented on PR #13127: URL: https://github.com/apache/kafka/pull/13127#issuecomment-1422322825 @cadonna , bumping this thread again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13127: KAFKA-14586: Moving StreamResetter to tools
vamossagar12 commented on PR #13127: URL: https://github.com/apache/kafka/pull/13127#issuecomment-1407272563 > @vamossagar12 Thanks for the PR! > > I had one major comment. Thanks @cadonna . I think that comment has been addressed now based on the conversation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13127: Kafka 14586: Moving StreamResetter to tools
vamossagar12 commented on PR #13127: URL: https://github.com/apache/kafka/pull/13127#issuecomment-1396439952 Adding @fvaleri . There are checkstyle issues, which I would fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13127: Kafka 14586: Moving StreamResetter to tools
vamossagar12 commented on PR #13127: URL: https://github.com/apache/kafka/pull/13127#issuecomment-1387469292 @mjsax , I noticed you had worked on the StreamsResetter tool. Would you be able to review this smallish PR? The idea is to move it from core module to tools module which is part of this: https://issues.apache.org/jira/browse/KAFKA-14525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
