[GitHub] [kafka] vamossagar12 commented on pull request #13733: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Connect plugin directory scan

2023-05-23 Thread via GitHub 


vamossagar12 commented on PR #13733:
URL: https://github.com/apache/kafka/pull/13733#issuecomment-1560458136

   Thanks @akatona84 for the clarification. If I go by what @gharris1727 is 
saying above, i.e 
   
   > When a directory is not accessible, only plugins within that directory 
should be missing. Plugins from other directories should still be visible if 
possible.
   
   then the changes that you have made in the PR become relevant. The changes 
look fine to me  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] vamossagar12 commented on pull request #13733: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Connect plugin directory scan

2023-05-19 Thread via GitHub 


vamossagar12 commented on PR #13733:
URL: https://github.com/apache/kafka/pull/13733#issuecomment-1555458221

   Thanks @akatona84 initially I had the same question as @divijvaidya but your 
explanation cleared up that doubt to some extent. If I understood the problem 
correctly that you described, the MM2 user failed because of the presence of a 
directory(.pki) which only a kafka user has access to. With this PR, MM2 user 
should be able to start MM2 cluster even though there's a directory to which it 
doesn't have access to.
   If that is the case, IMO the current behaviour is better that is we let 
things fail upfront and let the admins figure out what user groups should have 
access to which directories etc. Atleast with this, we won't have a case where 
the cluster can be brought in in an unexpected way. This is based on my 
understanding your explanation and there's a chance I might have missed 
something. Let me know what you think.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org