[GitHub] [kafka] vcrfxia commented on a diff in pull request #13365: KAFKA-14491: [17/N] Refactor segments cleanup logic
vcrfxia commented on code in PR #13365:
URL: https://github.com/apache/kafka/pull/13365#discussion_r1136263824
##
streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegments.java:
##
@@ -57,6 +57,11 @@ public void openExisting(final ProcessorContext context,
final long streamTime)
physicalStore.openDB(context.appConfigs(), context.stateDir());
}
+@Override
+public void cleanupExpiredSegments(final long streamTime) {
+super.cleanupExpiredSegments(streamTime);
Review Comment:
The method from AbstractSegments is protected, but LogicalKeyValueSegments
needs to expose it publicly so that it can be called from the versioned store
implementation.
Admittedly looks odd at first glance. I can add a comment into the code if
you think it'd be useful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] vcrfxia commented on a diff in pull request #13365: KAFKA-14491: [17/N] Refactor segments cleanup logic
vcrfxia commented on code in PR #13365:
URL: https://github.com/apache/kafka/pull/13365#discussion_r1136263824
##
streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegments.java:
##
@@ -57,6 +57,11 @@ public void openExisting(final ProcessorContext context,
final long streamTime)
physicalStore.openDB(context.appConfigs(), context.stateDir());
}
+@Override
+public void cleanupExpiredSegments(final long streamTime) {
+super.cleanupExpiredSegments(streamTime);
Review Comment:
The method from AbstractSegments is protected, but LogicalKeyValueSegments
needs to expose it publicly so that it can be called from the versioned store
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
