[GitHub] [kafka] vitojeng commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)
vitojeng commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-662796672 > Looking forward to the next PR(s) -- it's best to continue doing multiple smaller PRs (I leave it up to your judgment what the best way is to split the work in chunks.) Thanks @mjsax ! I would separate each new exception into different PRs. I guess this should be a better way for reviewing. Also thanks @brary for the reviewing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vitojeng commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)
vitojeng commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-661643910 > Thanks for the update @vitojeng -- a few more nits. Overall LGTM. Will merge after addressed. Thanks @mjsax for the reviewing, just updated, This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vitojeng commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)
vitojeng commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-660499985 @mjsax Thanks for the review. Already address your comment. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vitojeng commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)
vitojeng commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-660422567 Sorry, should not rebase... I'll force-push again! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vitojeng commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)
vitojeng commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-642387584 Got it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vitojeng commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)
vitojeng commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-642347591 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vitojeng commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)
vitojeng commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-642347229 Address comments and rebase trunk. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vitojeng commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)
vitojeng commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-635718737 @mjsax Just rebase & force-pushed. You can start review when you available. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vitojeng commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)
vitojeng commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-635703849 > Hey @vitojeng -- sorry for the long delay... We had a big KIP review back log... Never mind, I understand. :) I'll be rebase master again and update this PR ASAP. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
