[GitHub] [kafka] vvcephei commented on a change in pull request #9107: KAFKA-5488: Add type-safe split() operator
vvcephei commented on a change in pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#discussion_r565519912
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/BranchedKStream.java
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.streams.kstream;
+
+import java.util.Map;
+
+/**
+ * Branches the records in the original stream based on the predicates
supplied for the branch definitions.
+ *
+ * Branches are defined with {@link BranchedKStream#branch(Predicate,
Branched)} or
+ * {@link BranchedKStream#defaultBranch(Branched)} methods. Each record is
evaluated against the predicates
+ * supplied via {@link Branched} parameters, and is routed to the first branch
for which its respective predicate
+ * evaluates to {@code true}. If a record does not match any predicates, it
will be routed to the default branch,
+ * or dropped if no default branch is created.
+ *
+ * Each branch (which is a {@link KStream} instance) then can be processed
either by
+ * a {@link java.util.function.Function} or a {@link
java.util.function.Consumer} provided via a {@link Branched}
+ * parameter. If certain conditions are met, it also can be accessed from the
{@link Map} returned by
+ * {@link BranchedKStream#defaultBranch(Branched)} or {@link
BranchedKStream#noDefaultBranch()}
+ * (see usage examples).
+ *
+ * The branching happens on first-match: A record in the original stream is
assigned to the corresponding result
Review comment:
Yes, I agree, unless you want to add a noun:
```suggestion
* The branching happens on a first-match basis: A record in the original
stream is assigned to the corresponding result
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] vvcephei commented on a change in pull request #9107: KAFKA-5488: Add type-safe split() operator
vvcephei commented on a change in pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#discussion_r565519066
##
File path: streams/src/main/java/org/apache/kafka/streams/kstream/Branched.java
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.streams.kstream;
+
+import java.util.Objects;
+import java.util.function.Consumer;
+import java.util.function.Function;
+
+/**
+ * The {@code Branched} class is used to define the optional parameters when
building branches with
+ * {@link BranchedKStream}.
+ *
+ * @param type of record key
+ * @param type of record value
+ */
+public class Branched implements NamedOperation> {
+
+protected final String name;
+protected final Function, ? extends KStream>
chainFunction;
+protected final Consumer> chainConsumer;
+
+protected Branched(final String name,
+ final Function, ? extends
KStream> chainFunction,
+ final Consumer> chainConsumer) {
+this.name = name;
+this.chainFunction = chainFunction;
+this.chainConsumer = chainConsumer;
+}
+
+/**
+ * Create an instance of {@code Branched} with provided branch name suffix.
+ *
+ * @param name the branch name suffix to be used. If {@code null}, a
default branch name suffix will be generated
+ * (see {@link BranchedKStream} description for details)
+ * @param key type
+ * @param value type
+ * @return a new instance of {@code Branched}
+ */
+public static Branched as(final String name) {
+return new Branched<>(name, null, null);
Review comment:
I agree, it seems like a good idea to check for `null` here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
