[GitHub] [kafka] vvcephei commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.
vvcephei commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-892677574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.
vvcephei commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-893016769 There were still 21 test failures, but they do not look related to this change. There are also fixes ongoing in parallel to other tests, so I'm going to go ahead and merge this one. If it turns out to be the cause of new problems, we should just revert it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.
vvcephei commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-892707889 There were a number of failures in the prior run. Some were timeouts, and some of the Streams failures were due to the HA assignor giving only standbys to some nodes. I re-ran the tests (https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4635/) * with "spot instance" disabled * having added a change to the Streams tests intended to disable the HA assignor logic in favor of a one-shot balanced assignment. I'll keep an eye on that test run to make sure it's clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.
vvcephei commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-892677574 Thanks @kamalcph . Sorry it took me so long to look into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.
vvcephei commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-892354449 I went ahead and kicked off a full system test build to evaluate the other tests that got changed in this PR: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4633/console -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.
vvcephei commented on pull request #10602:
URL: https://github.com/apache/kafka/pull/10602#issuecomment-892354208
Ok, I figured it out. The problem was that this change was adding the new
version(s) to the _metadata_ upgrade test, but there isn't a metadata upgrade
between 2.x and 3.0. Since we're down to the wire now, I just went ahead and
pushed a fix to this branch.
It passes for me locally now:
```
[john@arcturus kafka]$
TC_PATHS="tests/kafkatest/tests/streams/streams_application_upgrade_test.py::StreamsUpgradeTest.test_app_upgrade"
_DUCKTAPE_OPTIONS='--parameters
'\''{"from_version":"2.8.0","to_version":"3.1.0-SNAPSHOT","bounce_type":"full"}'\'
bash tests/docker/run_tests.sh
docker exec ducker01 bash -c "cd /opt/kafka-dev && ducktape --cluster-file
/opt/kafka-dev/tests/docker/build/cluster.json
./tests/kafkatest/tests/streams/streams_application_upgrade_test.py::StreamsUpgradeTest.test_app_upgrade
--parameters
'{"from_version":"2.8.0","to_version":"3.1.0-SNAPSHOT","bounce_type":"full"}'"
[INFO:2021-08-03 21:27:59,868]: starting test run with session id
2021-08-03--012...
[INFO:2021-08-03 21:27:59,868]: running 1 tests...
[INFO:2021-08-03 21:27:59,869]: Triggering test 1 of 1...
[INFO:2021-08-03 21:27:59,878]: RunnerClient: Loading test {'directory':
'/opt/kafka-dev/tests/kafkatest/tests/streams', 'file_name':
'streams_application_upgrade_test.py', 'cls_name': 'StreamsUpgradeTest',
'method_name': 'test_app_upgrade', 'injected_args': {'from_version': '2.8.0',
'to_version': '3.1.0-SNAPSHOT', 'bounce_type': 'full'}}
[INFO:2021-08-03 21:27:59,883]: RunnerClient:
kafkatest.tests.streams.streams_application_upgrade_test.StreamsUpgradeTest.test_app_upgrade.from_version=2.8.0.to_version=3.1.0-SNAPSHOT.bounce_type=full:
Setting up...
[INFO:2021-08-03 21:27:59,884]: RunnerClient:
kafkatest.tests.streams.streams_application_upgrade_test.StreamsUpgradeTest.test_app_upgrade.from_version=2.8.0.to_version=3.1.0-SNAPSHOT.bounce_type=full:
Running...
[INFO:2021-08-03 21:29:44,814]: RunnerClient:
kafkatest.tests.streams.streams_application_upgrade_test.StreamsUpgradeTest.test_app_upgrade.from_version=2.8.0.to_version=3.1.0-SNAPSHOT.bounce_type=full:
PASS
[INFO:2021-08-03 21:29:44,816]: RunnerClient:
kafkatest.tests.streams.streams_application_upgrade_test.StreamsUpgradeTest.test_app_upgrade.from_version=2.8.0.to_version=3.1.0-SNAPSHOT.bounce_type=full:
Tearing down...
[INFO:2021-08-03 21:30:03,898]: RunnerClient:
kafkatest.tests.streams.streams_application_upgrade_test.StreamsUpgradeTest.test_app_upgrade.from_version=2.8.0.to_version=3.1.0-SNAPSHOT.bounce_type=full:
Summary:
[INFO:2021-08-03 21:30:03,899]: RunnerClient:
kafkatest.tests.streams.streams_application_upgrade_test.StreamsUpgradeTest.test_app_upgrade.from_version=2.8.0.to_version=3.1.0-SNAPSHOT.bounce_type=full:
Data: None
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.1
session_id: 2021-08-03--012
run time: 2 minutes 4.072 seconds
tests run:1
passed: 1
failed: 0
ignored: 0
test_id:
kafkatest.tests.streams.streams_application_upgrade_test.StreamsUpgradeTest.test_app_upgrade.from_version=2.8.0.to_version=3.1.0-SNAPSHOT.bounce_type=full
status: PASS
run time: 2 minutes 4.014 seconds
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.
vvcephei commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-876765383 Hmm, I had some trouble with the required pip version... I went ahead and kicked off: I haven't verified it, but I think your problem is that you needed to do `./gradlew clean systemTestLibs` instead of `:streams:testAll`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.
vvcephei commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-876758534 Hmm, I had some trouble with the required pip version... I went ahead and kicked off https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4586/ while I debug my local env. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.
vvcephei commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-876748402 Thanks, @kamalcph ! I'll take a look now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.
vvcephei commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-874917948 Hi @kamalcph , what's the status of this PR? I noticed there are some unresolved code review comments, and there are some conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
