[GitHub] [kafka] wcarlson5 commented on pull request #10356: KAFKA-12503: cache size set by the thread

2021-03-18 Thread GitBox 


wcarlson5 commented on pull request #10356:
URL: https://github.com/apache/kafka/pull/10356#issuecomment-802393840


   @guozhangwang @ableegoldman Can you take a look?
   
   @vvcephei I think this needs to be picked to 2.8 as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] wcarlson5 commented on pull request #10356: KAFKA-12503: cache size set by the thread

2021-03-18 Thread GitBox 


wcarlson5 commented on pull request #10356:
URL: https://github.com/apache/kafka/pull/10356#issuecomment-802427967


   I will don't know about testing this via an integration test. I worry about 
introducing just another flaky test, these types of issue get caught mostly in 
soak. Even with the optimal conditions for it to go wrong it took a couple days.
   
   I will think about how to improve the tests but that will happen in a 
different PR for sure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org