Re: [PR] [Draft] KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]
jolshan closed pull request #14731: [Draft] KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest URL: https://github.com/apache/kafka/pull/14731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Draft] KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]
jolshan commented on PR #14731: URL: https://github.com/apache/kafka/pull/14731#issuecomment-1949185760 Closing in favor of https://github.com/apache/kafka/pull/15384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Draft] KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]
RamanVerma commented on PR #14731: URL: https://github.com/apache/kafka/pull/14731#issuecomment-1944354242 > Hey @RamanVerma what is left here? We decided to bump the API version in the KIP. That and some testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Draft] KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]
jolshan commented on PR #14731: URL: https://github.com/apache/kafka/pull/14731#issuecomment-1944349380 Hey @RamanVerma what is left here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Draft] KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]
github-actions[bot] commented on PR #14731: URL: https://github.com/apache/kafka/pull/14731#issuecomment-1943032470 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Draft] KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]
artemlivshits commented on code in PR #14731:
URL: https://github.com/apache/kafka/pull/14731#discussion_r1394891315
##
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##
@@ -327,6 +328,7 @@ class TransactionStateManager(brokerId: Int,
}
def shouldInclude(txnMetadata: TransactionMetadata): Boolean = {
+ val now : Long = System.currentTimeMillis()
Review Comment:
Can we move this outside of the callback so that all transactions would be
checked against the same timestamp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
