Re: [PR] KAFKA-12317: fix documentation [kafka]
mjsax commented on PR #15689: URL: https://github.com/apache/kafka/pull/15689#issuecomment-2151057059 Thanks for the PR @florin-akermann. Merged to `trunk` and cherry-picked to `3.8` and `3.7` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-12317: fix documentation [kafka]
mjsax merged PR #15689: URL: https://github.com/apache/kafka/pull/15689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-12317: fix documentation [kafka]
florin-akermann commented on PR #15689: URL: https://github.com/apache/kafka/pull/15689#issuecomment-2094077287 Thanks @AyoubOm & @mjsax > I agree with @AyoubOm that both statements you intend to remove are still correct? Indeed, yes. > It seems https://github.com/apache/kafka/pull/14107 remove it incorrectly for inner join instead of left join? Removed from left join and added old statement again to inner join. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-12317: fix documentation [kafka]
mjsax commented on PR #15689: URL: https://github.com/apache/kafka/pull/15689#issuecomment-2084338816 Thanks for the PR @florin-akermann. I agree with @AyoubOm that both statements you intend to remove are still correct? Seems the stream-stream join section did not talk about null-keys and thus left/outer join do not need an update? Might be worth to update the stream-stream inner join row, to point out that null-key records are dropped? I also just checked FK-left join, and it still says (this statement is missing for inner-join though): > Records for which the foreignKeyExtractor produces null are ignored and do not trigger a join. If you want to join with null foreign keys, use a suitable sentinel value to do so (i.e. "NULL" for a String field, or -1 for an auto-incrementing integer field). It seems https://github.com/apache/kafka/pull/14107 remove it incorrectly for inner join instead of left join? Might be worth to go over the docs once more to double check (I made a pass, but might have missed something). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-12317: fix documentation [kafka]
AyoubOm commented on code in PR #15689: URL: https://github.com/apache/kafka/pull/15689#discussion_r1561381861 ## docs/streams/developer-guide/dsl-api.html: ## @@ -1952,11 +1947,6 @@ The join will be triggered under the conditions listed below whenever new input is received. When it is triggered, the user-supplied ValueJoiner will be called to produce join output records. - - -Input records with a null value are ignored and do not trigger the join. Review Comment: same comment as above ## docs/streams/developer-guide/dsl-api.html: ## @@ -1891,11 +1891,6 @@ The join will be triggered under the conditions listed below whenever new input is received. When it is triggered, the user-supplied ValueJoiner will be called to produce join output records. - - -Input records with a null value are ignored and do not trigger the join. Review Comment: For me, this line is still accurate after the feature KAFKA-12317. If I am not mistaken, It's records with null keys (and non null value) which are no longer ignored -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] KAFKA-12317: fix documentation [kafka]
florin-akermann opened a new pull request, #15689: URL: https://github.com/apache/kafka/pull/15689 Fix outdated documentation with regards to KAFKA-12317. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
