Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
ijuma commented on PR #14623: URL: https://github.com/apache/kafka/pull/14623#issuecomment-1788808631 Sounds good, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
divijvaidya merged PR #14623: URL: https://github.com/apache/kafka/pull/14623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
divijvaidya commented on PR #14623: URL: https://github.com/apache/kafka/pull/14623#issuecomment-1788782355 @ijuma I am merging this in without waiting for your approval since the changes are straightforward and your comments have been addressed. Please leave a comment if something is missing and we can follow up in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
divijvaidya commented on PR #14623: URL: https://github.com/apache/kafka/pull/14623#issuecomment-1788780081 Test failures are unrelated: ``` [Build / JDK 11 and Scala 2.13 / org.apache.kafka.clients.consumer.CooperativeStickyAssignorTest.testLargeAssignmentAndGroupWithNonEqualSubscription(boolean).hasConsumerRack = false](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14623/6/testReport/junit/org.apache.kafka.clients.consumer/CooperativeStickyAssignorTest/Build___JDK_11_and_Scala_2_13___testLargeAssignmentAndGroupWithNonEqualSubscription_boolean__hasConsumerRack___false/) [Build / JDK 11 and Scala 2.13 / org.apache.kafka.clients.consumer.StickyAssignorTest.testLargeAssignmentAndGroupWithNonEqualSubscription(boolean).hasConsumerRack = false](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14623/6/testReport/junit/org.apache.kafka.clients.consumer/StickyAssignorTest/Build___JDK_11_and_Scala_2_13___testLargeAssignmentAndGroupWithNonEqualSubscription_boolean__hasConsumerRack___false/) [Build / JDK 11 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testFenceMultipleBrokers()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14623/6/testReport/junit/org.apache.kafka.controller/QuorumControllerTest/Build___JDK_11_and_Scala_2_13___testFenceMultipleBrokers__/) [Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.StoreQueryIntegrationTest.shouldQuerySpecificStalePartitionStoresMultiStreamThreads()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14623/6/testReport/junit/org.apache.kafka.streams.integration/StoreQueryIntegrationTest/Build___JDK_17_and_Scala_2_13___shouldQuerySpecificStalePartitionStoresMultiStreamThreads__/) [Build / JDK 8 and Scala 2.12 / kafka.server.ReplicaManagerTest.[1] enableRemoteStorage=true](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14623/6/testReport/junit/kafka.server/ReplicaManagerTest/Build___JDK_8_and_Scala_2_121__enableRemoteStorage_true/) [Build / JDK 8 and Scala 2.12 / kafka.server.ReplicaManagerTest.[1] enableRemoteStorage=true](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14623/6/testReport/junit/kafka.server/ReplicaManagerTest/Build___JDK_8_and_Scala_2_121__enableRemoteStorage_true_2/) [Build / JDK 8 and Scala 2.12 / kafka.zk.ZkMigrationIntegrationTest.[4] Type=ZK, MetadataVersion=3.7-IV0, Security=PLAINTEXT](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14623/6/testReport/junit/kafka.zk/ZkMigrationIntegrationTest/Build___JDK_8_and_Scala_2_124__Type_ZK__MetadataVersion_3_7_IV0__Security_PLAINTEXT/) [Build / JDK 21 and Scala 2.13 / integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor(String).quorum=zk](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14623/6/testReport/junit/integration.kafka.server/FetchFromFollowerIntegrationTest/Build___JDK_21_and_Scala_2_13___testRackAwareRangeAssignor_String__quorum_zk/) [Build / JDK 21 and Scala 2.13 / org.apache.kafka.streams.integration.ConsistencyVectorIntegrationTest.shouldHaveSamePositionBoundActiveAndStandBy](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14623/6/testReport/junit/org.apache.kafka.streams.integration/ConsistencyVectorIntegrationTest/Build___JDK_21_and_Scala_2_13___shouldHaveSamePositionBoundActiveAndStandBy/) [Build / JDK 21 and Scala 2.13 / org.apache.kafka.streams.integration.RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14623/6/testReport/junit/org.apache.kafka.streams.integration/RestoreIntegrationTest/Build___JDK_21_and_Scala_2_13___shouldInvokeUserDefinedGlobalStateRestoreListener__/) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
clolov commented on PR #14623: URL: https://github.com/apache/kafka/pull/14623#issuecomment-1788663042 Heya @ijuma and @divijvaidya, none of the test failures are related to the test being changed in this pull request and the build passes! I hope I have addressed all of your comments and this is ready to merge but if not, let me know what else I can do! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
clolov commented on PR #14623: URL: https://github.com/apache/kafka/pull/14623#issuecomment-1787369618 No failures in `StreamsMetricsImplTest` in the last build! I will just make the final changes based on comments and this should be good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
ijuma commented on code in PR #14623: URL: https://github.com/apache/kafka/pull/14623#discussion_r1374763427 ## gradle/dependencies.gradle: ## @@ -70,8 +70,9 @@ else // The default strategy (i.e. what `mockito-core` uses) changed to `inline` in 5.x because it works better with newer // Java versions. // We always use the `inline` strategy. +// For Scala 2.12 we have to use the mockito-inline library because otherwise we cannot return mocks of final classes. Review Comment: Yes, we don't run Scala 2.12 with Java 11+ so it would not impact the PR builds. ## gradle/dependencies.gradle: ## @@ -70,8 +70,9 @@ else // The default strategy (i.e. what `mockito-core` uses) changed to `inline` in 5.x because it works better with newer // Java versions. // We always use the `inline` strategy. +// For Scala 2.12 we have to use the mockito-inline library because otherwise we cannot return mocks of final classes. Review Comment: Yes, we don't run Scala 2.12 with Java 11+ in CI so it would not impact the PR builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
clolov commented on code in PR #14623: URL: https://github.com/apache/kafka/pull/14623#discussion_r1374684030 ## gradle/dependencies.gradle: ## @@ -70,8 +70,9 @@ else // The default strategy (i.e. what `mockito-core` uses) changed to `inline` in 5.x because it works better with newer // Java versions. // We always use the `inline` strategy. +// For Scala 2.12 we have to use the mockito-inline library because otherwise we cannot return mocks of final classes. Review Comment: Yes, you are absolutely correct. Unfortunately, even with the additional check I still cannot quite make all the tests to pass, so I will continue battling this. But thank you for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
ijuma commented on code in PR #14623: URL: https://github.com/apache/kafka/pull/14623#discussion_r1374596662 ## gradle/dependencies.gradle: ## @@ -70,8 +70,9 @@ else // The default strategy (i.e. what `mockito-core` uses) changed to `inline` in 5.x because it works better with newer // Java versions. // We always use the `inline` strategy. +// For Scala 2.12 we have to use the mockito-inline library because otherwise we cannot return mocks of final classes. Review Comment: This comment is not accurate, `mockito-core` from version `5` does support that. The issue is that Scala 2.12 uses mockito 4. So, the additional check makes sense, but the comment doesn't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
ijuma commented on code in PR #14623: URL: https://github.com/apache/kafka/pull/14623#discussion_r1374596662 ## gradle/dependencies.gradle: ## @@ -70,8 +70,9 @@ else // The default strategy (i.e. what `mockito-core` uses) changed to `inline` in 5.x because it works better with newer // Java versions. // We always use the `inline` strategy. +// For Scala 2.12 we have to use the mockito-inline library because otherwise we cannot return mocks of final classes. Review Comment: This comment is not accurate, `mockito-core` from version `5` does support that. The issue is that Scala 2.12 uses mockito 4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
clolov commented on code in PR #14623:
URL: https://github.com/apache/kafka/pull/14623#discussion_r1373087790
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java:
##
@@ -1293,43 +1204,33 @@ private void verifyMetric(final String name,
public void shouldMeasureLatency() {
final long startTime = 6;
final long endTime = 10;
-final Sensor sensor = createMock(Sensor.class);
-expect(sensor.shouldRecord()).andReturn(true);
-expect(sensor.hasMetrics()).andReturn(true);
-sensor.record(endTime - startTime);
+final Sensor sensor = mock(Sensor.class);
+when(sensor.shouldRecord()).thenReturn(true);
+when(sensor.hasMetrics()).thenReturn(true);
+doNothing().when(sensor).record(endTime - startTime);
Review Comment:
If I add `doNothing().when(sensor).checkQuotas();` in this test I get the
following error when running the whole test suite:
```
org.mockito.exceptions.misusing.UnnecessaryStubbingException:
Unnecessary stubbings detected in test class: StreamsMetricsImplTest
Clean & maintainable test code requires zero unnecessary code.
Following stubbings are unnecessary (click to navigate to relevant line of
code):
1. -> at
org.apache.kafka.streams.processor.internals.metrics.StreamsMetricsImplTest.shouldMeasureLatency(StreamsMetricsImplTest.java:1209)
```
As such, I believe this means that the verification is carried out on these
stubs as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
clolov commented on code in PR #14623:
URL: https://github.com/apache/kafka/pull/14623#discussion_r1372833090
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java:
##
@@ -1293,43 +1204,33 @@ private void verifyMetric(final String name,
public void shouldMeasureLatency() {
final long startTime = 6;
final long endTime = 10;
-final Sensor sensor = createMock(Sensor.class);
-expect(sensor.shouldRecord()).andReturn(true);
-expect(sensor.hasMetrics()).andReturn(true);
-sensor.record(endTime - startTime);
+final Sensor sensor = mock(Sensor.class);
+when(sensor.shouldRecord()).thenReturn(true);
+when(sensor.hasMetrics()).thenReturn(true);
+doNothing().when(sensor).record(endTime - startTime);
Review Comment:
I will aim to double-check, but I was operating under this assumption!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
clolov commented on code in PR #14623:
URL: https://github.com/apache/kafka/pull/14623#discussion_r1372832772
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java:
##
@@ -146,69 +135,26 @@ public class StreamsMetricsImplTest {
private final MockTime time = new MockTime(0);
private final StreamsMetricsImpl streamsMetrics = new
StreamsMetricsImpl(metrics, CLIENT_ID, VERSION, time);
-private static MetricConfig eqMetricConfig(final MetricConfig
metricConfig) {
-EasyMock.reportMatcher(new IArgumentMatcher() {
-private final StringBuffer message = new StringBuffer();
-
-@Override
-public boolean matches(final Object argument) {
-if (argument instanceof MetricConfig) {
-final MetricConfig otherMetricConfig = (MetricConfig)
argument;
-final boolean equalsComparisons =
-(otherMetricConfig.quota() == metricConfig.quota() ||
-
otherMetricConfig.quota().equals(metricConfig.quota())) &&
-otherMetricConfig.tags().equals(metricConfig.tags());
-if (otherMetricConfig.eventWindow() ==
metricConfig.eventWindow() &&
-otherMetricConfig.recordLevel() ==
metricConfig.recordLevel() &&
-equalsComparisons &&
-otherMetricConfig.samples() == metricConfig.samples()
&&
-otherMetricConfig.timeWindowMs() ==
metricConfig.timeWindowMs()) {
-
-return true;
-} else {
-message.append("{ ");
-message.append("eventWindow=");
-message.append(otherMetricConfig.eventWindow());
-message.append(", ");
-message.append("recordLevel=");
-message.append(otherMetricConfig.recordLevel());
-message.append(", ");
-message.append("quota=");
-message.append(otherMetricConfig.quota().toString());
-message.append(", ");
-message.append("samples=");
-message.append(otherMetricConfig.samples());
-message.append(", ");
-message.append("tags=");
-message.append(otherMetricConfig.tags().toString());
-message.append(", ");
-message.append("timeWindowMs=");
-message.append(otherMetricConfig.timeWindowMs());
-message.append(" }");
-}
-}
-message.append("not a MetricConfig object");
-return false;
-}
-
-@Override
-public void appendTo(final StringBuffer buffer) {
-buffer.append(message);
-}
-});
-return null;
-}
-
-private Capture addSensorsOnAllLevels(final Metrics metrics, final
StreamsMetricsImpl streamsMetrics) {
-final Capture sensorKeys = newCapture(CaptureType.ALL);
+private static boolean eqMetricConfig(final MetricConfig thisMetricConfig,
final MetricConfig thatMetricConfig) {
Review Comment:
Okay, makes sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
clolov commented on PR #14623: URL: https://github.com/apache/kafka/pull/14623#issuecomment-1780706599 I am able to reproduce the failing tests locally and I am trying to understand why the behaviour is not as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
divijvaidya commented on code in PR #14623:
URL: https://github.com/apache/kafka/pull/14623#discussion_r1372120378
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java:
##
@@ -1293,43 +1204,33 @@ private void verifyMetric(final String name,
public void shouldMeasureLatency() {
final long startTime = 6;
final long endTime = 10;
-final Sensor sensor = createMock(Sensor.class);
-expect(sensor.shouldRecord()).andReturn(true);
-expect(sensor.hasMetrics()).andReturn(true);
-sensor.record(endTime - startTime);
+final Sensor sensor = mock(Sensor.class);
+when(sensor.shouldRecord()).thenReturn(true);
+when(sensor.hasMetrics()).thenReturn(true);
+doNothing().when(sensor).record(endTime - startTime);
Review Comment:
for my curiosity, does strict subs verify usage of stubs defined using
`doNothin()` as well or just for subs defined using `when()`
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java:
##
@@ -146,69 +135,26 @@ public class StreamsMetricsImplTest {
private final MockTime time = new MockTime(0);
private final StreamsMetricsImpl streamsMetrics = new
StreamsMetricsImpl(metrics, CLIENT_ID, VERSION, time);
-private static MetricConfig eqMetricConfig(final MetricConfig
metricConfig) {
-EasyMock.reportMatcher(new IArgumentMatcher() {
-private final StringBuffer message = new StringBuffer();
-
-@Override
-public boolean matches(final Object argument) {
-if (argument instanceof MetricConfig) {
-final MetricConfig otherMetricConfig = (MetricConfig)
argument;
-final boolean equalsComparisons =
-(otherMetricConfig.quota() == metricConfig.quota() ||
-
otherMetricConfig.quota().equals(metricConfig.quota())) &&
-otherMetricConfig.tags().equals(metricConfig.tags());
-if (otherMetricConfig.eventWindow() ==
metricConfig.eventWindow() &&
-otherMetricConfig.recordLevel() ==
metricConfig.recordLevel() &&
-equalsComparisons &&
-otherMetricConfig.samples() == metricConfig.samples()
&&
-otherMetricConfig.timeWindowMs() ==
metricConfig.timeWindowMs()) {
-
-return true;
-} else {
-message.append("{ ");
-message.append("eventWindow=");
-message.append(otherMetricConfig.eventWindow());
-message.append(", ");
-message.append("recordLevel=");
-message.append(otherMetricConfig.recordLevel());
-message.append(", ");
-message.append("quota=");
-message.append(otherMetricConfig.quota().toString());
-message.append(", ");
-message.append("samples=");
-message.append(otherMetricConfig.samples());
-message.append(", ");
-message.append("tags=");
-message.append(otherMetricConfig.tags().toString());
-message.append(", ");
-message.append("timeWindowMs=");
-message.append(otherMetricConfig.timeWindowMs());
-message.append(" }");
-}
-}
-message.append("not a MetricConfig object");
-return false;
-}
-
-@Override
-public void appendTo(final StringBuffer buffer) {
-buffer.append(message);
-}
-});
-return null;
-}
-
-private Capture addSensorsOnAllLevels(final Metrics metrics, final
StreamsMetricsImpl streamsMetrics) {
-final Capture sensorKeys = newCapture(CaptureType.ALL);
+private static boolean eqMetricConfig(final MetricConfig thisMetricConfig,
final MetricConfig thatMetricConfig) {
Review Comment:
This we are not printing details when assertion fails, can you please add a
message to print the thatMetricConfig similar to
`assertTrue(eqMetricConfig(expected, actual), "my message here")`
Will help in debugging failed tests and maintain parity with existing code.
Maybe someone added such detailed logging in one place because debugging this
was very hard!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructu
Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
clolov commented on PR #14623: URL: https://github.com/apache/kafka/pull/14623#issuecomment-1778922834 Local run of the failing tests passes: ``` > Configure project : Starting build with version 3.7.0-SNAPSHOT (commit id 79afb498) using Gradle 8.3, Java 1.8 and Scala 2.13.12 Build properties: maxParallelForks=10, maxScalacThreads=8, maxTestRetries=0 > Task :storage:storage-api:processResources NO-SOURCE > Task :streams:processResources UP-TO-DATE > Task :storage:processResources UP-TO-DATE > Task :group-coordinator:processResources UP-TO-DATE > Task :streams:createStreamsVersionFile UP-TO-DATE > Task :storage:createVersionFile UP-TO-DATE > Task :group-coordinator:processTestResources UP-TO-DATE > Task :raft:processResources UP-TO-DATE > Task :raft:processTestResources UP-TO-DATE > Task :raft:createVersionFile UP-TO-DATE > Task :storage:storage-api:processTestResources NO-SOURCE > Task :streams:processTestResources UP-TO-DATE > Task :storage:storage-api:createVersionFile UP-TO-DATE > Task :log4j-appender:processResources NO-SOURCE > Task :core:processResources UP-TO-DATE > Task :core:processTestResources UP-TO-DATE > Task :connect:json:processResources UP-TO-DATE > Task :metadata:processResources UP-TO-DATE > Task :connect:test-plugins:processResources UP-TO-DATE > Task :connect:runtime:processResources UP-TO-DATE > Task :tools:processResources NO-SOURCE > Task :metadata:processTestResources UP-TO-DATE > Task :connect:api:processResources UP-TO-DATE > Task :connect:transforms:processResources UP-TO-DATE > Task :clients:processResources UP-TO-DATE > Task :clients:createVersionFile UP-TO-DATE > Task :clients:processTestResources UP-TO-DATE > Task :tools:tools-api:processResources NO-SOURCE > Task :server-common:processResources NO-SOURCE > Task :tools:tools-api:createVersionFile UP-TO-DATE > Task :server-common:processTestResources UP-TO-DATE > Task :streams:test-utils:processResources NO-SOURCE > Task :server-common:createVersionFile UP-TO-DATE > Task :connect:runtime:processTestResources UP-TO-DATE > Task :generator:compileJava UP-TO-DATE > Task :generator:processResources NO-SOURCE > Task :generator:classes UP-TO-DATE > Task :generator:jar UP-TO-DATE > Task :core:processMessages UP-TO-DATE > Task :streams:processMessages UP-TO-DATE > Task :clients:processMessages UP-TO-DATE > Task :metadata:processMessages UP-TO-DATE > Task :group-coordinator:processMessages UP-TO-DATE > Task :raft:processMessages UP-TO-DATE > Task :storage:processMessages UP-TO-DATE > Task :clients:compileJava UP-TO-DATE > Task :clients:classes UP-TO-DATE > Task :tools:tools-api:compileJava UP-TO-DATE > Task :tools:tools-api:classes UP-TO-DATE > Task :clients:jar UP-TO-DATE > Task :tools:tools-api:jar UP-TO-DATE > Task :clients:processTestMessages UP-TO-DATE > Task :server-common:compileJava UP-TO-DATE > Task :streams:compileJava UP-TO-DATE > Task :streams:classes UP-TO-DATE > Task :streams:copyDependantLibs UP-TO-DATE > Task :connect:api:compileJava UP-TO-DATE > Task :server-common:classes UP-TO-DATE > Task :log4j-appender:compileJava UP-TO-DATE > Task :log4j-appender:classes UP-TO-DATE > Task :storage:storage-api:compileJava UP-TO-DATE > Task :log4j-appender:jar UP-TO-DATE > Task :server-common:jar UP-TO-DATE > Task :storage:storage-api:classes UP-TO-DATE > Task :streams:jar UP-TO-DATE > Task :storage:storage-api:jar UP-TO-DATE > Task :raft:compileJava UP-TO-DATE > Task :connect:json:compileJava UP-TO-DATE > Task :raft:classes UP-TO-DATE > Task :connect:transforms:compileJava UP-TO-DATE > Task :connect:api:classes UP-TO-DATE > Task :connect:json:classes UP-TO-DATE > Task :raft:jar UP-TO-DATE > Task :connect:transforms:classes UP-TO-DATE > Task :streams:test-utils:compileJava UP-TO-DATE > Task :streams:test-utils:classes UP-TO-DATE > Task :connect:test-plugins:compileJava UP-TO-DATE > Task :connect:test-plugins:classes UP-TO-DATE > Task :streams:test-utils:copyDependantLibs UP-TO-DATE > Task :connect:test-plugins:jar UP-TO-DATE > Task :streams:test-utils:jar UP-TO-DATE > Task :metadata:compileJava UP-TO-DATE > Task :storage:compileJava UP-TO-DATE > Task :metadata:classes UP-TO-DATE > Task :storage:classes UP-TO-DATE > Task :clients:compileTestJava UP-TO-DATE > Task :clients:testClasses UP-TO-DATE > Task :metadata:jar UP-TO-DATE > Task :group-coordinator:compileJava UP-TO-DATE > Task :core:compileJava NO-SOURCE > Task :group-coordinator:classes UP-TO-DATE > Task :storage:storage-api:compileTestJava UP-TO-DATE > Task :storage:storage-api:testClasses UP-TO-DATE > Task :server-common:compileTestJava UP-TO-DATE > Task :group-coordinator:jar UP-TO-DATE > Task :server-common:testClasses UP-TO-DATE > Task :storage:jar UP-TO-DATE > Task :
[PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]
clolov opened a new pull request, #14623: URL: https://github.com/apache/kafka/pull/14623 This pull requests migrates mocks from StreamsMetricsImplTest to Mockito. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
