Re: [PR] KAFKA-14467:Add a test to validate the replica state after processing the OFFSET_MOVED_TO_TIERED_STORAGE error [kafka]

[via GitHub]

showuon commented on PR #14652:
URL: https://github.com/apache/kafka/pull/14652#issuecomment-1951760048

   @hudeqi , are you still interested in completing this PR? There seems to 
have some unaddressed comments..=


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14467:Add a test to validate the replica state after processing the OFFSET_MOVED_TO_TIERED_STORAGE error [kafka]

[via GitHub]

github-actions[bot] commented on PR #14652:
URL: https://github.com/apache/kafka/pull/14652#issuecomment-1951633659

   This PR is being marked as stale since it has not had any activity in 90 
days. If you would like to keep this PR alive, please ask a committer for 
review. If the PR has  merge conflicts, please update it with the latest from 
trunk (or appropriate release branch)  If this PR is no longer valid or 
desired, please feel free to close it. If no activity occurs in the next 30 
days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14467:Add a test to validate the replica state after processing the OFFSET_MOVED_TO_TIERED_STORAGE error [kafka]

[via GitHub]

hudeqi commented on code in PR #14652:
URL: https://github.com/apache/kafka/pull/14652#discussion_r1398987952


##
core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java:
##
@@ -238,12 +238,8 @@ private Long buildRemoteLogAuxState(TopicPartition 
topicPartition,
 
 log.debug("Updated the epoch cache from remote tier till 
offset: {} with size: {} for {}", leaderLocalLogStartOffset, epochs.size(), 
partition);
 
-// Restore producer snapshot
-File snapshotFile = 
LogFileUtils.producerSnapshotFile(unifiedLog.dir(), nextOffset);
-buildProducerSnapshotFile(snapshotFile, 
remoteLogSegmentMetadata, rlm);
-
 // Reload producer snapshots.
-
unifiedLog.producerStateManager().truncateFullyAndReloadSnapshots();
+truncateFullyAndReloadRestoredSnapshots(unifiedLog, 
nextOffset, remoteLogSegmentMetadata, rlm);

Review Comment:
   updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org