Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
jolshan merged PR #15248: URL: https://github.com/apache/kafka/pull/15248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
jolshan commented on PR #15248: URL: https://github.com/apache/kafka/pull/15248#issuecomment-1912499332 Sorry I meant to check this one yesterday but accidentally looked at your other PR. I thought I was waiting on build issues there, but should have been looking here. Looking now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
nizhikov commented on PR #15248: URL: https://github.com/apache/kafka/pull/15248#issuecomment-1910366005 Hello @jolshan Do you have any other questions regarding this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465593791
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.consumer.group;
+
+import kafka.admin.ConsumerGroupCommand;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientTestUtils;
+import org.apache.kafka.clients.admin.ConsumerGroupDescription;
+import org.apache.kafka.clients.admin.DescribeConsumerGroupsResult;
+import org.apache.kafka.clients.admin.DescribeTopicsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.ListOffsetsResult;
+import org.apache.kafka.clients.admin.ListOffsetsResult.ListOffsetsResultInfo;
+import org.apache.kafka.clients.admin.MemberAssignment;
+import org.apache.kafka.clients.admin.MemberDescription;
+import org.apache.kafka.clients.admin.OffsetSpec;
+import org.apache.kafka.clients.admin.TopicDescription;
+import org.apache.kafka.clients.consumer.OffsetAndMetadata;
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.kafka.common.ConsumerGroupState;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.TopicPartitionInfo;
+import org.apache.kafka.common.internals.KafkaFutureImpl;
+import org.apache.kafka.common.utils.Utils;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import scala.Option;
+import scala.Some;
+import scala.Tuple2;
+import scala.collection.JavaConverters;
+import scala.collection.Seq;
+import scala.collection.immutable.Map$;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ConsumerGroupServiceTest {
+public static final String GROUP = "testGroup";
+
+public static final int NUM_PARTITIONS = 10;
+
+private static final List TOPICS = IntStream.range(0,
5).mapToObj(i -> "testTopic" + i).collect(Collectors.toList());
+
+private static final List TOPIC_PARTITIONS =
TOPICS.stream()
+.flatMap(topic -> IntStream.range(0, NUM_PARTITIONS).mapToObj(i ->
new TopicPartition(topic, i)))
+.collect(Collectors.toList());
+
+private final Admin admin = mock(Admin.class);
+
+@Test
+public void testAdminRequestsForDescribeOffsets() {
+String[] args = new String[]{"--bootstrap-server", "localhost:9092",
"--group", GROUP, "--describe", "--offsets"};
+ConsumerGroupCommand.ConsumerGroupService groupService =
consumerGroupService(args);
+
+
when(admin.describeConsumerGroups(ArgumentMatchers.eq(Collections.singletonList(GROUP)),
any()))
+.thenReturn(describeGroupsResult(ConsumerGroupState.STABLE));
+
when(admin.listConsumerGroupOffsets(ArgumentMatchers.eq(listConsumerGroupOffsetsSpec()),
any()))
+.thenReturn(listGroupOffsetsResult(GROUP));
+when(admin.listOffsets(offsetsArgMatcher(), any()))
+.thenReturn(listOffsetsResult());
+
+Tuple2,
Option>> res =
groupService.collectGroupOffsets(GROUP);
+assertEquals(Some.apply("Stable"), res._1);
+assertTrue(res._2.isDefined());
+assertEquals(TOPIC_PARTITIONS.size(), res._2.get().size());
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465593791
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.consumer.group;
+
+import kafka.admin.ConsumerGroupCommand;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientTestUtils;
+import org.apache.kafka.clients.admin.ConsumerGroupDescription;
+import org.apache.kafka.clients.admin.DescribeConsumerGroupsResult;
+import org.apache.kafka.clients.admin.DescribeTopicsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.ListOffsetsResult;
+import org.apache.kafka.clients.admin.ListOffsetsResult.ListOffsetsResultInfo;
+import org.apache.kafka.clients.admin.MemberAssignment;
+import org.apache.kafka.clients.admin.MemberDescription;
+import org.apache.kafka.clients.admin.OffsetSpec;
+import org.apache.kafka.clients.admin.TopicDescription;
+import org.apache.kafka.clients.consumer.OffsetAndMetadata;
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.kafka.common.ConsumerGroupState;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.TopicPartitionInfo;
+import org.apache.kafka.common.internals.KafkaFutureImpl;
+import org.apache.kafka.common.utils.Utils;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import scala.Option;
+import scala.Some;
+import scala.Tuple2;
+import scala.collection.JavaConverters;
+import scala.collection.Seq;
+import scala.collection.immutable.Map$;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ConsumerGroupServiceTest {
+public static final String GROUP = "testGroup";
+
+public static final int NUM_PARTITIONS = 10;
+
+private static final List TOPICS = IntStream.range(0,
5).mapToObj(i -> "testTopic" + i).collect(Collectors.toList());
+
+private static final List TOPIC_PARTITIONS =
TOPICS.stream()
+.flatMap(topic -> IntStream.range(0, NUM_PARTITIONS).mapToObj(i ->
new TopicPartition(topic, i)))
+.collect(Collectors.toList());
+
+private final Admin admin = mock(Admin.class);
+
+@Test
+public void testAdminRequestsForDescribeOffsets() {
+String[] args = new String[]{"--bootstrap-server", "localhost:9092",
"--group", GROUP, "--describe", "--offsets"};
+ConsumerGroupCommand.ConsumerGroupService groupService =
consumerGroupService(args);
+
+
when(admin.describeConsumerGroups(ArgumentMatchers.eq(Collections.singletonList(GROUP)),
any()))
+.thenReturn(describeGroupsResult(ConsumerGroupState.STABLE));
+
when(admin.listConsumerGroupOffsets(ArgumentMatchers.eq(listConsumerGroupOffsetsSpec()),
any()))
+.thenReturn(listGroupOffsetsResult(GROUP));
+when(admin.listOffsets(offsetsArgMatcher(), any()))
+.thenReturn(listOffsetsResult());
+
+Tuple2,
Option>> res =
groupService.collectGroupOffsets(GROUP);
+assertEquals(Some.apply("Stable"), res._1);
+assertTrue(res._2.isDefined());
+assertEquals(TOPIC_PARTITIONS.size(), res._2.get().size());
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
nizhikov commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465587429
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.consumer.group;
+
+import kafka.admin.ConsumerGroupCommand;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientTestUtils;
+import org.apache.kafka.clients.admin.ConsumerGroupDescription;
+import org.apache.kafka.clients.admin.DescribeConsumerGroupsResult;
+import org.apache.kafka.clients.admin.DescribeTopicsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.ListOffsetsResult;
+import org.apache.kafka.clients.admin.ListOffsetsResult.ListOffsetsResultInfo;
+import org.apache.kafka.clients.admin.MemberAssignment;
+import org.apache.kafka.clients.admin.MemberDescription;
+import org.apache.kafka.clients.admin.OffsetSpec;
+import org.apache.kafka.clients.admin.TopicDescription;
+import org.apache.kafka.clients.consumer.OffsetAndMetadata;
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.kafka.common.ConsumerGroupState;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.TopicPartitionInfo;
+import org.apache.kafka.common.internals.KafkaFutureImpl;
+import org.apache.kafka.common.utils.Utils;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import scala.Option;
+import scala.Some;
+import scala.Tuple2;
+import scala.collection.JavaConverters;
+import scala.collection.Seq;
+import scala.collection.immutable.Map$;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ConsumerGroupServiceTest {
+public static final String GROUP = "testGroup";
+
+public static final int NUM_PARTITIONS = 10;
+
+private static final List TOPICS = IntStream.range(0,
5).mapToObj(i -> "testTopic" + i).collect(Collectors.toList());
+
+private static final List TOPIC_PARTITIONS =
TOPICS.stream()
+.flatMap(topic -> IntStream.range(0, NUM_PARTITIONS).mapToObj(i ->
new TopicPartition(topic, i)))
+.collect(Collectors.toList());
+
+private final Admin admin = mock(Admin.class);
+
+@Test
+public void testAdminRequestsForDescribeOffsets() {
+String[] args = new String[]{"--bootstrap-server", "localhost:9092",
"--group", GROUP, "--describe", "--offsets"};
+ConsumerGroupCommand.ConsumerGroupService groupService =
consumerGroupService(args);
+
+
when(admin.describeConsumerGroups(ArgumentMatchers.eq(Collections.singletonList(GROUP)),
any()))
+.thenReturn(describeGroupsResult(ConsumerGroupState.STABLE));
+
when(admin.listConsumerGroupOffsets(ArgumentMatchers.eq(listConsumerGroupOffsetsSpec()),
any()))
+.thenReturn(listGroupOffsetsResult(GROUP));
+when(admin.listOffsets(offsetsArgMatcher(), any()))
+.thenReturn(listOffsetsResult());
+
+Tuple2,
Option>>
statesAndAssignments = groupService.collectGroupOffsets(GROUP);
+assertEquals(Some.apply("Stable"), statesAndAssignments._1);
+assertTrue(statesAndAssignments._2.isDefined());
+
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
nizhikov commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465586005
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.consumer.group;
+
+import kafka.admin.ConsumerGroupCommand;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientTestUtils;
+import org.apache.kafka.clients.admin.ConsumerGroupDescription;
+import org.apache.kafka.clients.admin.DescribeConsumerGroupsResult;
+import org.apache.kafka.clients.admin.DescribeTopicsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.ListOffsetsResult;
+import org.apache.kafka.clients.admin.ListOffsetsResult.ListOffsetsResultInfo;
+import org.apache.kafka.clients.admin.MemberAssignment;
+import org.apache.kafka.clients.admin.MemberDescription;
+import org.apache.kafka.clients.admin.OffsetSpec;
+import org.apache.kafka.clients.admin.TopicDescription;
+import org.apache.kafka.clients.consumer.OffsetAndMetadata;
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.kafka.common.ConsumerGroupState;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.TopicPartitionInfo;
+import org.apache.kafka.common.internals.KafkaFutureImpl;
+import org.apache.kafka.common.utils.Utils;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import scala.Option;
+import scala.Some;
+import scala.Tuple2;
+import scala.collection.JavaConverters;
+import scala.collection.Seq;
+import scala.collection.immutable.Map$;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ConsumerGroupServiceTest {
+public static final String GROUP = "testGroup";
+
+public static final int NUM_PARTITIONS = 10;
+
+private static final List TOPICS = IntStream.range(0,
5).mapToObj(i -> "testTopic" + i).collect(Collectors.toList());
+
+private static final List TOPIC_PARTITIONS =
TOPICS.stream()
+.flatMap(topic -> IntStream.range(0, NUM_PARTITIONS).mapToObj(i ->
new TopicPartition(topic, i)))
+.collect(Collectors.toList());
+
+private final Admin admin = mock(Admin.class);
+
+@Test
+public void testAdminRequestsForDescribeOffsets() {
+String[] args = new String[]{"--bootstrap-server", "localhost:9092",
"--group", GROUP, "--describe", "--offsets"};
+ConsumerGroupCommand.ConsumerGroupService groupService =
consumerGroupService(args);
+
+
when(admin.describeConsumerGroups(ArgumentMatchers.eq(Collections.singletonList(GROUP)),
any()))
+.thenReturn(describeGroupsResult(ConsumerGroupState.STABLE));
+
when(admin.listConsumerGroupOffsets(ArgumentMatchers.eq(listConsumerGroupOffsetsSpec()),
any()))
+.thenReturn(listGroupOffsetsResult(GROUP));
+when(admin.listOffsets(offsetsArgMatcher(), any()))
+.thenReturn(listOffsetsResult());
+
+Tuple2,
Option>> res =
groupService.collectGroupOffsets(GROUP);
+assertEquals(Some.apply("Stable"), res._1);
+assertTrue(res._2.isDefined());
+assertEquals(TOPIC_PARTITIONS.size(), res._2.get().size());
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465585471
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.consumer.group;
+
+import kafka.admin.ConsumerGroupCommand;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientTestUtils;
+import org.apache.kafka.clients.admin.ConsumerGroupDescription;
+import org.apache.kafka.clients.admin.DescribeConsumerGroupsResult;
+import org.apache.kafka.clients.admin.DescribeTopicsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.ListOffsetsResult;
+import org.apache.kafka.clients.admin.ListOffsetsResult.ListOffsetsResultInfo;
+import org.apache.kafka.clients.admin.MemberAssignment;
+import org.apache.kafka.clients.admin.MemberDescription;
+import org.apache.kafka.clients.admin.OffsetSpec;
+import org.apache.kafka.clients.admin.TopicDescription;
+import org.apache.kafka.clients.consumer.OffsetAndMetadata;
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.kafka.common.ConsumerGroupState;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.TopicPartitionInfo;
+import org.apache.kafka.common.internals.KafkaFutureImpl;
+import org.apache.kafka.common.utils.Utils;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import scala.Option;
+import scala.Some;
+import scala.Tuple2;
+import scala.collection.JavaConverters;
+import scala.collection.Seq;
+import scala.collection.immutable.Map$;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ConsumerGroupServiceTest {
+public static final String GROUP = "testGroup";
+
+public static final int NUM_PARTITIONS = 10;
+
+private static final List TOPICS = IntStream.range(0,
5).mapToObj(i -> "testTopic" + i).collect(Collectors.toList());
+
+private static final List TOPIC_PARTITIONS =
TOPICS.stream()
+.flatMap(topic -> IntStream.range(0, NUM_PARTITIONS).mapToObj(i ->
new TopicPartition(topic, i)))
+.collect(Collectors.toList());
+
+private final Admin admin = mock(Admin.class);
+
+@Test
+public void testAdminRequestsForDescribeOffsets() {
+String[] args = new String[]{"--bootstrap-server", "localhost:9092",
"--group", GROUP, "--describe", "--offsets"};
+ConsumerGroupCommand.ConsumerGroupService groupService =
consumerGroupService(args);
+
+
when(admin.describeConsumerGroups(ArgumentMatchers.eq(Collections.singletonList(GROUP)),
any()))
+.thenReturn(describeGroupsResult(ConsumerGroupState.STABLE));
+
when(admin.listConsumerGroupOffsets(ArgumentMatchers.eq(listConsumerGroupOffsetsSpec()),
any()))
+.thenReturn(listGroupOffsetsResult(GROUP));
+when(admin.listOffsets(offsetsArgMatcher(), any()))
+.thenReturn(listOffsetsResult());
+
+Tuple2,
Option>>
statesAndAssignments = groupService.collectGroupOffsets(GROUP);
+assertEquals(Some.apply("Stable"), statesAndAssignments._1);
+assertTrue(statesAndAssignments._2.isDefined());
+
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
nizhikov commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465574942
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.consumer.group;
+
+import kafka.admin.ConsumerGroupCommand;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientTestUtils;
+import org.apache.kafka.clients.admin.ConsumerGroupDescription;
+import org.apache.kafka.clients.admin.DescribeConsumerGroupsResult;
+import org.apache.kafka.clients.admin.DescribeTopicsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.ListOffsetsResult;
+import org.apache.kafka.clients.admin.ListOffsetsResult.ListOffsetsResultInfo;
+import org.apache.kafka.clients.admin.MemberAssignment;
+import org.apache.kafka.clients.admin.MemberDescription;
+import org.apache.kafka.clients.admin.OffsetSpec;
+import org.apache.kafka.clients.admin.TopicDescription;
+import org.apache.kafka.clients.consumer.OffsetAndMetadata;
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.kafka.common.ConsumerGroupState;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.TopicPartitionInfo;
+import org.apache.kafka.common.internals.KafkaFutureImpl;
+import org.apache.kafka.common.utils.Utils;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import scala.Option;
+import scala.Some;
+import scala.Tuple2;
+import scala.collection.JavaConverters;
+import scala.collection.Seq;
+import scala.collection.immutable.Map$;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ConsumerGroupServiceTest {
+public static final String GROUP = "testGroup";
+
+public static final int NUM_PARTITIONS = 10;
+
+private static final List TOPICS = IntStream.range(0,
5).mapToObj(i -> "testTopic" + i).collect(Collectors.toList());
+
+private static final List TOPIC_PARTITIONS =
TOPICS.stream()
+.flatMap(topic -> IntStream.range(0, NUM_PARTITIONS).mapToObj(i ->
new TopicPartition(topic, i)))
+.collect(Collectors.toList());
+
+private final Admin admin = mock(Admin.class);
+
+@Test
+public void testAdminRequestsForDescribeOffsets() {
+String[] args = new String[]{"--bootstrap-server", "localhost:9092",
"--group", GROUP, "--describe", "--offsets"};
+ConsumerGroupCommand.ConsumerGroupService groupService =
consumerGroupService(args);
+
+
when(admin.describeConsumerGroups(ArgumentMatchers.eq(Collections.singletonList(GROUP)),
any()))
+.thenReturn(describeGroupsResult(ConsumerGroupState.STABLE));
+
when(admin.listConsumerGroupOffsets(ArgumentMatchers.eq(listConsumerGroupOffsetsSpec()),
any()))
+.thenReturn(listGroupOffsetsResult(GROUP));
+when(admin.listOffsets(offsetsArgMatcher(), any()))
+.thenReturn(listOffsetsResult());
+
+Tuple2,
Option>>
statesAndAssignments = groupService.collectGroupOffsets(GROUP);
+assertEquals(Some.apply("Stable"), statesAndAssignments._1);
+assertTrue(statesAndAssignments._2.isDefined());
+
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465353561
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.consumer.group;
+
+import kafka.admin.ConsumerGroupCommand;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientTestUtils;
+import org.apache.kafka.clients.admin.ConsumerGroupDescription;
+import org.apache.kafka.clients.admin.DescribeConsumerGroupsResult;
+import org.apache.kafka.clients.admin.DescribeTopicsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.ListOffsetsResult;
+import org.apache.kafka.clients.admin.ListOffsetsResult.ListOffsetsResultInfo;
+import org.apache.kafka.clients.admin.MemberAssignment;
+import org.apache.kafka.clients.admin.MemberDescription;
+import org.apache.kafka.clients.admin.OffsetSpec;
+import org.apache.kafka.clients.admin.TopicDescription;
+import org.apache.kafka.clients.consumer.OffsetAndMetadata;
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.kafka.common.ConsumerGroupState;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.TopicPartitionInfo;
+import org.apache.kafka.common.internals.KafkaFutureImpl;
+import org.apache.kafka.common.utils.Utils;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import scala.Option;
+import scala.Some;
+import scala.Tuple2;
+import scala.collection.JavaConverters;
+import scala.collection.Seq;
+import scala.collection.immutable.Map$;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ConsumerGroupServiceTest {
+public static final String GROUP = "testGroup";
+
+public static final int NUM_PARTITIONS = 10;
+
+private static final List TOPICS = IntStream.range(0,
5).mapToObj(i -> "testTopic" + i).collect(Collectors.toList());
+
+private static final List TOPIC_PARTITIONS =
TOPICS.stream()
+.flatMap(topic -> IntStream.range(0, NUM_PARTITIONS).mapToObj(i ->
new TopicPartition(topic, i)))
+.collect(Collectors.toList());
+
+private final Admin admin = mock(Admin.class);
+
+@Test
+public void testAdminRequestsForDescribeOffsets() {
+String[] args = new String[]{"--bootstrap-server", "localhost:9092",
"--group", GROUP, "--describe", "--offsets"};
+ConsumerGroupCommand.ConsumerGroupService groupService =
consumerGroupService(args);
+
+
when(admin.describeConsumerGroups(ArgumentMatchers.eq(Collections.singletonList(GROUP)),
any()))
+.thenReturn(describeGroupsResult(ConsumerGroupState.STABLE));
+
when(admin.listConsumerGroupOffsets(ArgumentMatchers.eq(listConsumerGroupOffsetsSpec()),
any()))
+.thenReturn(listGroupOffsetsResult(GROUP));
+when(admin.listOffsets(offsetsArgMatcher(), any()))
+.thenReturn(listOffsetsResult());
+
+Tuple2,
Option>>
statesAndAssignments = groupService.collectGroupOffsets(GROUP);
+assertEquals(Some.apply("Stable"), statesAndAssignments._1);
+assertTrue(statesAndAssignments._2.isDefined());
+
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465353561
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.consumer.group;
+
+import kafka.admin.ConsumerGroupCommand;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientTestUtils;
+import org.apache.kafka.clients.admin.ConsumerGroupDescription;
+import org.apache.kafka.clients.admin.DescribeConsumerGroupsResult;
+import org.apache.kafka.clients.admin.DescribeTopicsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.ListOffsetsResult;
+import org.apache.kafka.clients.admin.ListOffsetsResult.ListOffsetsResultInfo;
+import org.apache.kafka.clients.admin.MemberAssignment;
+import org.apache.kafka.clients.admin.MemberDescription;
+import org.apache.kafka.clients.admin.OffsetSpec;
+import org.apache.kafka.clients.admin.TopicDescription;
+import org.apache.kafka.clients.consumer.OffsetAndMetadata;
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.kafka.common.ConsumerGroupState;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.TopicPartitionInfo;
+import org.apache.kafka.common.internals.KafkaFutureImpl;
+import org.apache.kafka.common.utils.Utils;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import scala.Option;
+import scala.Some;
+import scala.Tuple2;
+import scala.collection.JavaConverters;
+import scala.collection.Seq;
+import scala.collection.immutable.Map$;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ConsumerGroupServiceTest {
+public static final String GROUP = "testGroup";
+
+public static final int NUM_PARTITIONS = 10;
+
+private static final List TOPICS = IntStream.range(0,
5).mapToObj(i -> "testTopic" + i).collect(Collectors.toList());
+
+private static final List TOPIC_PARTITIONS =
TOPICS.stream()
+.flatMap(topic -> IntStream.range(0, NUM_PARTITIONS).mapToObj(i ->
new TopicPartition(topic, i)))
+.collect(Collectors.toList());
+
+private final Admin admin = mock(Admin.class);
+
+@Test
+public void testAdminRequestsForDescribeOffsets() {
+String[] args = new String[]{"--bootstrap-server", "localhost:9092",
"--group", GROUP, "--describe", "--offsets"};
+ConsumerGroupCommand.ConsumerGroupService groupService =
consumerGroupService(args);
+
+
when(admin.describeConsumerGroups(ArgumentMatchers.eq(Collections.singletonList(GROUP)),
any()))
+.thenReturn(describeGroupsResult(ConsumerGroupState.STABLE));
+
when(admin.listConsumerGroupOffsets(ArgumentMatchers.eq(listConsumerGroupOffsetsSpec()),
any()))
+.thenReturn(listGroupOffsetsResult(GROUP));
+when(admin.listOffsets(offsetsArgMatcher(), any()))
+.thenReturn(listOffsetsResult());
+
+Tuple2,
Option>>
statesAndAssignments = groupService.collectGroupOffsets(GROUP);
+assertEquals(Some.apply("Stable"), statesAndAssignments._1);
+assertTrue(statesAndAssignments._2.isDefined());
+
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465346754
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.consumer.group;
+
+import kafka.admin.ConsumerGroupCommand;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientTestUtils;
+import org.apache.kafka.clients.admin.ConsumerGroupDescription;
+import org.apache.kafka.clients.admin.DescribeConsumerGroupsResult;
+import org.apache.kafka.clients.admin.DescribeTopicsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.ListOffsetsResult;
+import org.apache.kafka.clients.admin.ListOffsetsResult.ListOffsetsResultInfo;
+import org.apache.kafka.clients.admin.MemberAssignment;
+import org.apache.kafka.clients.admin.MemberDescription;
+import org.apache.kafka.clients.admin.OffsetSpec;
+import org.apache.kafka.clients.admin.TopicDescription;
+import org.apache.kafka.clients.consumer.OffsetAndMetadata;
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.kafka.common.ConsumerGroupState;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.TopicPartitionInfo;
+import org.apache.kafka.common.internals.KafkaFutureImpl;
+import org.apache.kafka.common.utils.Utils;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import scala.Option;
+import scala.Some;
+import scala.Tuple2;
+import scala.collection.JavaConverters;
+import scala.collection.Seq;
+import scala.collection.immutable.Map$;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ConsumerGroupServiceTest {
+public static final String GROUP = "testGroup";
+
+public static final int NUM_PARTITIONS = 10;
+
+private static final List TOPICS = IntStream.range(0,
5).mapToObj(i -> "testTopic" + i).collect(Collectors.toList());
+
+private static final List TOPIC_PARTITIONS =
TOPICS.stream()
+.flatMap(topic -> IntStream.range(0, NUM_PARTITIONS).mapToObj(i ->
new TopicPartition(topic, i)))
+.collect(Collectors.toList());
+
+private final Admin admin = mock(Admin.class);
+
+@Test
+public void testAdminRequestsForDescribeOffsets() {
+String[] args = new String[]{"--bootstrap-server", "localhost:9092",
"--group", GROUP, "--describe", "--offsets"};
+ConsumerGroupCommand.ConsumerGroupService groupService =
consumerGroupService(args);
+
+
when(admin.describeConsumerGroups(ArgumentMatchers.eq(Collections.singletonList(GROUP)),
any()))
+.thenReturn(describeGroupsResult(ConsumerGroupState.STABLE));
+
when(admin.listConsumerGroupOffsets(ArgumentMatchers.eq(listConsumerGroupOffsetsSpec()),
any()))
+.thenReturn(listGroupOffsetsResult(GROUP));
+when(admin.listOffsets(offsetsArgMatcher(), any()))
+.thenReturn(listOffsetsResult());
+
+Tuple2,
Option>> res =
groupService.collectGroupOffsets(GROUP);
+assertEquals(Some.apply("Stable"), res._1);
+assertTrue(res._2.isDefined());
+assertEquals(TOPIC_PARTITIONS.size(), res._2.get().size());
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
nizhikov commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465339215
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.consumer.group;
+
+import kafka.admin.ConsumerGroupCommand;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientTestUtils;
+import org.apache.kafka.clients.admin.ConsumerGroupDescription;
+import org.apache.kafka.clients.admin.DescribeConsumerGroupsResult;
+import org.apache.kafka.clients.admin.DescribeTopicsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.ListOffsetsResult;
+import org.apache.kafka.clients.admin.ListOffsetsResult.ListOffsetsResultInfo;
+import org.apache.kafka.clients.admin.MemberAssignment;
+import org.apache.kafka.clients.admin.MemberDescription;
+import org.apache.kafka.clients.admin.OffsetSpec;
+import org.apache.kafka.clients.admin.TopicDescription;
+import org.apache.kafka.clients.consumer.OffsetAndMetadata;
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.kafka.common.ConsumerGroupState;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.TopicPartitionInfo;
+import org.apache.kafka.common.internals.KafkaFutureImpl;
+import org.apache.kafka.common.utils.Utils;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import scala.Option;
+import scala.Some;
+import scala.Tuple2;
+import scala.collection.JavaConverters;
+import scala.collection.Seq;
+import scala.collection.immutable.Map$;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ConsumerGroupServiceTest {
+public static final String GROUP = "testGroup";
+
+public static final int NUM_PARTITIONS = 10;
+
+private static final List TOPICS = IntStream.range(0,
5).mapToObj(i -> "testTopic" + i).collect(Collectors.toList());
+
+private static final List TOPIC_PARTITIONS =
TOPICS.stream()
+.flatMap(topic -> IntStream.range(0, NUM_PARTITIONS).mapToObj(i ->
new TopicPartition(topic, i)))
+.collect(Collectors.toList());
+
+private final Admin admin = mock(Admin.class);
+
+@Test
+public void testAdminRequestsForDescribeOffsets() {
+String[] args = new String[]{"--bootstrap-server", "localhost:9092",
"--group", GROUP, "--describe", "--offsets"};
+ConsumerGroupCommand.ConsumerGroupService groupService =
consumerGroupService(args);
+
+
when(admin.describeConsumerGroups(ArgumentMatchers.eq(Collections.singletonList(GROUP)),
any()))
+.thenReturn(describeGroupsResult(ConsumerGroupState.STABLE));
+
when(admin.listConsumerGroupOffsets(ArgumentMatchers.eq(listConsumerGroupOffsetsSpec()),
any()))
+.thenReturn(listGroupOffsetsResult(GROUP));
+when(admin.listOffsets(offsetsArgMatcher(), any()))
+.thenReturn(listOffsetsResult());
+
+Tuple2,
Option>> res =
groupService.collectGroupOffsets(GROUP);
+assertEquals(Some.apply("Stable"), res._1);
+assertTrue(res._2.isDefined());
+assertEquals(TOPIC_PARTITIONS.size(), res._2.get().size());
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
nizhikov commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465336810
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.consumer.group;
+
+import kafka.admin.ConsumerGroupCommand;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientTestUtils;
+import org.apache.kafka.clients.admin.ConsumerGroupDescription;
+import org.apache.kafka.clients.admin.DescribeConsumerGroupsResult;
+import org.apache.kafka.clients.admin.DescribeTopicsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.ListOffsetsResult;
+import org.apache.kafka.clients.admin.ListOffsetsResult.ListOffsetsResultInfo;
+import org.apache.kafka.clients.admin.MemberAssignment;
+import org.apache.kafka.clients.admin.MemberDescription;
+import org.apache.kafka.clients.admin.OffsetSpec;
+import org.apache.kafka.clients.admin.TopicDescription;
+import org.apache.kafka.clients.consumer.OffsetAndMetadata;
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.kafka.common.ConsumerGroupState;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.TopicPartitionInfo;
+import org.apache.kafka.common.internals.KafkaFutureImpl;
+import org.apache.kafka.common.utils.Utils;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import scala.Option;
+import scala.Some;
+import scala.Tuple2;
+import scala.collection.JavaConverters;
+import scala.collection.Seq;
+import scala.collection.immutable.Map$;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ConsumerGroupServiceTest {
+public static final String GROUP = "testGroup";
+
+public static final int NUM_PARTITIONS = 10;
+
+private static final List TOPICS = IntStream.range(0,
5).mapToObj(i -> "testTopic" + i).collect(Collectors.toList());
+
+private static final List TOPIC_PARTITIONS =
TOPICS.stream()
+.flatMap(topic -> IntStream.range(0, NUM_PARTITIONS).mapToObj(i ->
new TopicPartition(topic, i)))
+.collect(Collectors.toList());
+
+private final Admin admin = mock(Admin.class);
+
+@Test
+public void testAdminRequestsForDescribeOffsets() {
+String[] args = new String[]{"--bootstrap-server", "localhost:9092",
"--group", GROUP, "--describe", "--offsets"};
+ConsumerGroupCommand.ConsumerGroupService groupService =
consumerGroupService(args);
+
+
when(admin.describeConsumerGroups(ArgumentMatchers.eq(Collections.singletonList(GROUP)),
any()))
+.thenReturn(describeGroupsResult(ConsumerGroupState.STABLE));
+
when(admin.listConsumerGroupOffsets(ArgumentMatchers.eq(listConsumerGroupOffsetsSpec()),
any()))
+.thenReturn(listGroupOffsetsResult(GROUP));
+when(admin.listOffsets(offsetsArgMatcher(), any()))
+.thenReturn(listOffsetsResult());
+
+Tuple2,
Option>> res =
groupService.collectGroupOffsets(GROUP);
+assertEquals(Some.apply("Stable"), res._1);
+assertTrue(res._2.isDefined());
+assertEquals(TOPIC_PARTITIONS.size(), res._2.get().size());
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465333784
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.consumer.group;
+
+import kafka.admin.ConsumerGroupCommand;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientTestUtils;
+import org.apache.kafka.clients.admin.ConsumerGroupDescription;
+import org.apache.kafka.clients.admin.DescribeConsumerGroupsResult;
+import org.apache.kafka.clients.admin.DescribeTopicsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.ListOffsetsResult;
+import org.apache.kafka.clients.admin.ListOffsetsResult.ListOffsetsResultInfo;
+import org.apache.kafka.clients.admin.MemberAssignment;
+import org.apache.kafka.clients.admin.MemberDescription;
+import org.apache.kafka.clients.admin.OffsetSpec;
+import org.apache.kafka.clients.admin.TopicDescription;
+import org.apache.kafka.clients.consumer.OffsetAndMetadata;
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.kafka.common.ConsumerGroupState;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.TopicPartitionInfo;
+import org.apache.kafka.common.internals.KafkaFutureImpl;
+import org.apache.kafka.common.utils.Utils;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import scala.Option;
+import scala.Some;
+import scala.Tuple2;
+import scala.collection.JavaConverters;
+import scala.collection.Seq;
+import scala.collection.immutable.Map$;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ConsumerGroupServiceTest {
+public static final String GROUP = "testGroup";
+
+public static final int NUM_PARTITIONS = 10;
+
+private static final List TOPICS = IntStream.range(0,
5).mapToObj(i -> "testTopic" + i).collect(Collectors.toList());
+
+private static final List TOPIC_PARTITIONS =
TOPICS.stream()
+.flatMap(topic -> IntStream.range(0, NUM_PARTITIONS).mapToObj(i ->
new TopicPartition(topic, i)))
+.collect(Collectors.toList());
+
+private final Admin admin = mock(Admin.class);
+
+@Test
+public void testAdminRequestsForDescribeOffsets() {
+String[] args = new String[]{"--bootstrap-server", "localhost:9092",
"--group", GROUP, "--describe", "--offsets"};
+ConsumerGroupCommand.ConsumerGroupService groupService =
consumerGroupService(args);
+
+
when(admin.describeConsumerGroups(ArgumentMatchers.eq(Collections.singletonList(GROUP)),
any()))
+.thenReturn(describeGroupsResult(ConsumerGroupState.STABLE));
+
when(admin.listConsumerGroupOffsets(ArgumentMatchers.eq(listConsumerGroupOffsetsSpec()),
any()))
+.thenReturn(listGroupOffsetsResult(GROUP));
+when(admin.listOffsets(offsetsArgMatcher(), any()))
+.thenReturn(listOffsetsResult());
+
+Tuple2,
Option>> res =
groupService.collectGroupOffsets(GROUP);
+assertEquals(Some.apply("Stable"), res._1);
+assertTrue(res._2.isDefined());
+assertEquals(TOPIC_PARTITIONS.size(), res._2.get().size());
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465332064
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.consumer.group;
+
+import kafka.admin.ConsumerGroupCommand;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientTestUtils;
+import org.apache.kafka.clients.admin.ConsumerGroupDescription;
+import org.apache.kafka.clients.admin.DescribeConsumerGroupsResult;
+import org.apache.kafka.clients.admin.DescribeTopicsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.ListOffsetsResult;
+import org.apache.kafka.clients.admin.ListOffsetsResult.ListOffsetsResultInfo;
+import org.apache.kafka.clients.admin.MemberAssignment;
+import org.apache.kafka.clients.admin.MemberDescription;
+import org.apache.kafka.clients.admin.OffsetSpec;
+import org.apache.kafka.clients.admin.TopicDescription;
+import org.apache.kafka.clients.consumer.OffsetAndMetadata;
+import org.apache.kafka.clients.consumer.RangeAssignor;
+import org.apache.kafka.common.ConsumerGroupState;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.TopicPartitionInfo;
+import org.apache.kafka.common.internals.KafkaFutureImpl;
+import org.apache.kafka.common.utils.Utils;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.ArgumentMatchers;
+import scala.Option;
+import scala.Some;
+import scala.Tuple2;
+import scala.collection.JavaConverters;
+import scala.collection.Seq;
+import scala.collection.immutable.Map$;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class ConsumerGroupServiceTest {
+public static final String GROUP = "testGroup";
+
+public static final int NUM_PARTITIONS = 10;
+
+private static final List TOPICS = IntStream.range(0,
5).mapToObj(i -> "testTopic" + i).collect(Collectors.toList());
+
+private static final List TOPIC_PARTITIONS =
TOPICS.stream()
+.flatMap(topic -> IntStream.range(0, NUM_PARTITIONS).mapToObj(i ->
new TopicPartition(topic, i)))
+.collect(Collectors.toList());
+
+private final Admin admin = mock(Admin.class);
+
+@Test
+public void testAdminRequestsForDescribeOffsets() {
+String[] args = new String[]{"--bootstrap-server", "localhost:9092",
"--group", GROUP, "--describe", "--offsets"};
+ConsumerGroupCommand.ConsumerGroupService groupService =
consumerGroupService(args);
+
+
when(admin.describeConsumerGroups(ArgumentMatchers.eq(Collections.singletonList(GROUP)),
any()))
+.thenReturn(describeGroupsResult(ConsumerGroupState.STABLE));
+
when(admin.listConsumerGroupOffsets(ArgumentMatchers.eq(listConsumerGroupOffsetsSpec()),
any()))
+.thenReturn(listGroupOffsetsResult(GROUP));
+when(admin.listOffsets(offsetsArgMatcher(), any()))
+.thenReturn(listOffsetsResult());
+
+Tuple2,
Option>> res =
groupService.collectGroupOffsets(GROUP);
Review Comment:
is there a way we could say what the tuple contains? like
`stateAndAssignments`
--
This is an automated message from the Apache Git
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
nizhikov commented on PR #15248: URL: https://github.com/apache/kafka/pull/15248#issuecomment-1908611036 Hello @showuon Can you, please, take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
nizhikov commented on PR #15248: URL: https://github.com/apache/kafka/pull/15248#issuecomment-1907703286 CI is OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
nizhikov commented on PR #15248: URL: https://github.com/apache/kafka/pull/15248#issuecomment-1906283629 @tledkov can you, please, take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-14589 ConsumerGroupServiceTest rewritten in java [kafka]
nizhikov commented on PR #15248: URL: https://github.com/apache/kafka/pull/15248#issuecomment-1906283217 Hello @mimaison , @jolshan I prepared second PR for KAFKA-14589. It contains `ConsumerGroupServiceTest` rewritten in java. Please, take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
