Re: [PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

[via GitHub]

jolshan commented on PR #14506:
URL: https://github.com/apache/kafka/pull/14506#issuecomment-1807174506

   Thanks @showuon for taking a look. Makes sense to me.
   I also saw the conversation here. https://github.com/apache/kafka/pull/14741 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

[via GitHub]

showuon commented on PR #14506:
URL: https://github.com/apache/kafka/pull/14506#issuecomment-1805278003

   @jolshan , I just created a [PR](https://github.com/apache/kafka/pull/14730) 
to revert the change in this PR, and the test results also failed 
`testSingleIP` test. So, let's keep monitoring it, and maybe we need to change 
the test, because resolving localhost into multiple IPs should be fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

[via GitHub]

showuon commented on PR #14506:
URL: https://github.com/apache/kafka/pull/14506#issuecomment-1805023823

   I had a look, and think this flaky test should be the infra's issue, not our 
code. Like you said, in 3.6 branch, after I backported this PR, it started to 
fail (on Nov. 9). Now, checking trunk build, it also failed on Nov. 9 and 10. 
   
   
https://ge.apache.org/scans/tests?search.names=git%20branch&search.rootProjectNames=kafka&search.startTimeMax=1699587001012&search.startTimeMin=169608960&search.timeZoneId=Asia%2FTaipei&search.values=trunk&tests.container=org.apache.kafka.clients.ClusterConnectionStatesTest#
   
   Back to the test code, it failed at this line: 
   `assertEquals(1, ClientUtils.resolve("localhost", 
singleIPHostResolver).size());`
   which basically our kafka logic won't impact this host resolver results. 
   
   So, I think we can keep monitoring it for now, and hope it can be 
self-healing. If not, we raise a issue to infra team, maybe? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

[via GitHub]

jolshan commented on PR #14506:
URL: https://github.com/apache/kafka/pull/14506#issuecomment-1804803577

   Hey I was taking a look at 3.6 builds and it looks like 
https://ci-builds.apache.org/job/Kafka/job/kafka/job/3.6/107/testReport/junit/org.apache.kafka.clients/ClusterConnectionStatesTest/Build___JDK_8_and_Scala_2_12___testSingleIP__/
 has been failing a lot more since this change.
   
   
https://ge.apache.org/scans/tests?search.names=git%20branch&search.relativeStartTime=P28D&search.rootProjectNames=kafka&search.timeZoneId=America%2FLos_Angeles&search.values=3.6&tests.container=org.apache.kafka.clients.ClusterConnectionStatesTest
   
   It has flaked on the build for 3.6 that it was merged, the next build, and 
my PR build targeted to 3.6. Can we make sure this change didn't cause issues?
   
   https://ci-builds.apache.org/job/Kafka/job/kafka/job/3.6/107/
   
https://ci-builds.apache.org/job/Kafka/job/kafka/job/3.6/108/#showFailuresLink
   
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14712/6/#showFailuresLink
   
   @showuon @mumrah @cmccabe 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

[via GitHub]

showuon commented on PR #14506:
URL: https://github.com/apache/kafka/pull/14506#issuecomment-1803521941

   Backported to 3.5 and 3.6 branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

[via GitHub]

cmccabe merged PR #14506:
URL: https://github.com/apache/kafka/pull/14506


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

[via GitHub]

mumrah opened a new pull request, #14506:
URL: https://github.com/apache/kafka/pull/14506

   This patch fixes a problem where we migrate the current producer ID batch to 
KRaft instead of the next producer ID batch. Since KRaft stores the _next_ 
batch in the log, we end up serving up a duplicate batch to the first caller of 
AllocateProducerIds once the KRaft controller has taken over.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org