Re: [PR] KAFKA-15715: Add Kraft Support to UpgradeFeaturesTest [kafka]

[via GitHub]

Owen-CH-Leung closed pull request #15429: KAFKA-15715: Add Kraft Support to 
UpgradeFeaturesTest
URL: https://github.com/apache/kafka/pull/15429


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15715: Add Kraft Support to UpgradeFeaturesTest [kafka]

[via GitHub]

dengziming commented on code in PR #15429:
URL: https://github.com/apache/kafka/pull/15429#discussion_r1504147458


##
core/src/test/scala/unit/kafka/server/UpdateFeaturesTest.scala:
##
@@ -31,13 +34,15 @@ import org.apache.kafka.common.protocol.Errors
 import org.apache.kafka.common.requests.{UpdateFeaturesRequest, 
UpdateFeaturesResponse}
 import org.apache.kafka.common.utils.Utils
 import org.apache.kafka.server.common.MetadataVersion.{IBP_2_7_IV0, 
IBP_3_2_IV0}
-import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.Assertions.{assertEquals, assertFalse, 
assertNotEquals, assertNotNull, assertThrows, assertTrue}
+import org.junit.jupiter.api.extension.ExtendWith
 
 import scala.jdk.CollectionConverters._
 import scala.reflect.ClassTag
 import scala.util.matching.Regex
 
+@ClusterTestDefaults(clusterType = Type.ALL)
+@ExtendWith(value = Array(classOf[ClusterTestExtensions]))
 class UpdateFeaturesTest extends BaseRequestTest {

Review Comment:
   We typically don't extends `BaseRequestTest` if we are using 
`ClusterTestExtensions`, we should use `UpdateFeaturesTest(cluster: 
ClusterInstance)` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] KAFKA-15715: Add Kraft Support to UpgradeFeaturesTest [kafka]

[via GitHub]

Owen-CH-Leung opened a new pull request, #15429:
URL: https://github.com/apache/kafka/pull/15429

   https://issues.apache.org/jira/browse/KAFKA-15715
   
   As per [KAFKA-15715](https://issues.apache.org/jira/browse/KAFKA-15715), 
this PR adds Kraft support to UpgradeFeaturesTest
   
   
   ### Committer Checklist (excluded from commit message)
   - [x] Verify design and implementation 
   - [x] Verify test coverage and CI build status
   - [x] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org