Re: [PR] KAFKA-15817: Avoid reconnecting to the same IP address if multiple ad… [kafka]

2023-11-30 Thread via GitHub


lucasbru commented on PR #14813:
URL: https://github.com/apache/kafka/pull/14813#issuecomment-1833276819

   @ijuma I did not. My understanding was that this shouldn't be included in 
3.6.1, so I was waiting for 3.6.1 to go through before cherry-picking it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15817: Avoid reconnecting to the same IP address if multiple ad… [kafka]

2023-11-29 Thread via GitHub


ijuma commented on PR #14813:
URL: https://github.com/apache/kafka/pull/14813#issuecomment-1833215345

   @lucasbru Did you cherry-pick to 3.6?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15817: Avoid reconnecting to the same IP address if multiple ad… [kafka]

2023-11-27 Thread via GitHub


lucasbru merged PR #14813:
URL: https://github.com/apache/kafka/pull/14813


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15817: Avoid reconnecting to the same IP address if multiple ad… [kafka]

2023-11-27 Thread via GitHub


lucasbru commented on PR #14813:
URL: https://github.com/apache/kafka/pull/14813#issuecomment-1827497554

   test failures are know flaky tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15817: Avoid reconnecting to the same IP address if multiple ad… [kafka]

2023-11-26 Thread via GitHub


ijuma commented on PR #14813:
URL: https://github.com/apache/kafka/pull/14813#issuecomment-1826881644

   Thanks for the PR. Let's cherry pick this to 3.6 after this is merged to 
master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] KAFKA-15817: Avoid reconnecting to the same IP address if multiple ad… [kafka]

2023-11-21 Thread via GitHub


bob-barrett opened a new pull request, #14813:
URL: https://github.com/apache/kafka/pull/14813

   …dresses are available
   
   This change is a follow-up to https://github.com/apache/kafka/pull/9902. 
When re-resolving DNS after disconnecting, it is possible (likely, even) that 
we will resolve the same set of addresses in the same order, meaning we could 
attempt to reconnect to the same IP that we just disconnected from. In the case 
where we disconnected from the IP address because it has become unhealthy (due 
to a load balancer going down or a network routing layer restarting, for 
example), the client will need to time out before connecting to the next IP. 
This essentially unifies the behavior before and after KAFKA-12193: re-resolve 
after disconnecting while still progressing through the IP list.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org