Re: [PR] KAFKA-15821: Delete active topics after connector deletion in standal… [kafka]
github-actions[bot] commented on PR #14776: URL: https://github.com/apache/kafka/pull/14776#issuecomment-1962236422 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15821: Delete active topics after connector deletion in standal… [kafka]
C0urante commented on PR #14776: URL: https://github.com/apache/kafka/pull/14776#issuecomment-1826433209 Thanks for the PR @djameson42! I agree with @hudeqi that we should have a test to cover this change and prevent regression. Also, not a blocker, but it seems a little strange to put this new logic in the config update listener instead of in [StandaloneHerder::deleteConnectorConfig](https://github.com/apache/kafka/blob/95f41d59b389b6f25000b7bc4ddb948cfdb90448/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java#L162), which is where almost all of the existing connector deletion logic is located. Any particular reason you've structured things this way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
