Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]
showuon merged PR #14760: URL: https://github.com/apache/kafka/pull/14760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]
showuon commented on PR #14760: URL: https://github.com/apache/kafka/pull/14760#issuecomment-2029112501 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]
gaurav-narula commented on code in PR #14760: URL: https://github.com/apache/kafka/pull/14760#discussion_r1545653758 ## core/src/main/scala/kafka/server/NodeToControllerChannelManager.scala: ## @@ -386,6 +386,7 @@ class NodeToControllerRequestThread( if (response.authenticationException != null) { error(s"Request ${queueItem.request} failed due to authentication error with controller", response.authenticationException) Review Comment: Thanks for the review! Addressed in [c405f73](https://github.com/apache/kafka/pull/14760/commits/c405f7387bcfc94845689d46588c9fc75cbb8596) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]
showuon commented on code in PR #14760: URL: https://github.com/apache/kafka/pull/14760#discussion_r1544017066 ## core/src/main/scala/kafka/server/NodeToControllerChannelManager.scala: ## @@ -386,6 +386,7 @@ class NodeToControllerRequestThread( if (response.authenticationException != null) { error(s"Request ${queueItem.request} failed due to authentication error with controller", response.authenticationException) Review Comment: Should we log: `Disconnecting the connection to the stale controller ${activeControllerAddress().map(_.idString).getOrElse("null")}` like what we did for `NOT_CONTROLLER` error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]
soarez commented on PR #14760: URL: https://github.com/apache/kafka/pull/14760#issuecomment-2026260420 This still needs a review from a committer. @mimaison @mumrah @rondagostino @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]
github-actions[bot] commented on PR #14760: URL: https://github.com/apache/kafka/pull/14760#issuecomment-1960687556 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]
gaurav-narula commented on PR #14760: URL: https://github.com/apache/kafka/pull/14760#issuecomment-1825242721 CC: @hachikuji since you've looked into the response handler recently. Can you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]
gaurav-narula opened a new pull request, #14760: URL: https://github.com/apache/kafka/pull/14760 This PR changes the handling of authenticationException on a request from the node to the controller. We disconnect controller connection and invalidate the cache so that the next run of the thread will establish a connection with the (potentially) updated controller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org