Re: [PR] KAFKA-15866:Refactor OffsetFetchRequestState Error handling [kafka]
github-actions[bot] commented on PR #14923: URL: https://github.com/apache/kafka/pull/14923#issuecomment-2001437254 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15866:Refactor OffsetFetchRequestState Error handling [kafka]
DL1231 commented on PR #14923: URL: https://github.com/apache/kafka/pull/14923#issuecomment-1859021289 @philipnee @dajac PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15866:Refactor OffsetFetchRequestState Error handling [kafka]
DL1231 commented on PR #14923: URL: https://github.com/apache/kafka/pull/14923#issuecomment-1841980081 @philipnee PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] KAFKA-15866:Refactor OffsetFetchRequestState Error handling [kafka]
DL1231 opened a new pull request, #14923: URL: https://github.com/apache/kafka/pull/14923 The PR resolve issue [KAFKA-15866](https://issues.apache.org/jira/browse/KAFKA-15866), the current OffsetFetchRequestState error handling uses nested if-else, which is quite different, stylistically, to the OffsetCommitRequestState using a switch statment. The latter is a bit more readable so we should refactor the error handling using the same style to improve readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
